Can specify delay in emit_fields for monsters #37895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 10, 2020 20:50
ZhilkinSerg
added
[C++]
This was referenced Feb 16, 2020
kevingranade
requested changes
Feb 22, 2020
There was a problem hiding this comment.
I'm not a fan of the array with the two different values, and even less a fan of putting a parser for it in units, this isn't really a standard construct we should be encouraging.
Also, you don't have to make this backwards incompatible, tit's fine to have the old style entry indicate that the duration is 1 second.
added 9 commits
February 22, 2020 13:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Can specify delay in emit_fields for monsters"Purpose of change
Can specify delay in emit_fields for monsters
[ My Sweet Cataclysm ] Gum spiders no longer spam gum webs every turn
Describe the solution
Change
emit_filedsfrom a set to a map of emit_id and time_durationsFix delay for gum spider
Update json for every monster in vanilla and mods
Describe alternatives you've considered
Testing
Spawn a gum spider
No spamming webs
Wait 30 min
Spider emits one web
Spawn incandesant husk
Constant field emission
Additional context