Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aftershock] Prepnet dialogue and itemgroup fixes #37950

Merged

Conversation

Maleclypse
Copy link
Member

Summary

SUMMARY: Bugfixes "Prepnet dialogue issues and item group fails"

Purpose of change

Fixes to dialogue confusion mentioned by players, and no item spawns attached to some items.

Describe the solution

Added appropriate items to item groups, created new item group, fixed dialogue.

Describe alternatives you've considered

Self immolating from shame.

Testing

Loaded it all up and tested. Seems to work.

Additional context

I'm fine with this fix waiting until 0.E if that helps. That way if it breaks anything past my test build, it doesn't create more work for anyone until the flying vehicles distract people from my failings.

@ZhilkinSerg ZhilkinSerg added Mods: Aftershock Anything to do with the Aftershock mod <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON labels Feb 12, 2020
Copy link
Member

@John-Candlebury John-Candlebury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you have here seems good to me!

@ZhilkinSerg ZhilkinSerg requested review from John-Candlebury and removed request for John-Candlebury February 12, 2020 20:56
@ZhilkinSerg ZhilkinSerg merged commit b0def6b into CleverRaven:master Feb 13, 2020
@Maleclypse Maleclypse deleted the Prepnet-Dialogue-Improvements branch April 13, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mods: Aftershock Anything to do with the Aftershock mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants