-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Aftershock] Prepnet dialogue and itemgroup fixes #37950
Merged
ZhilkinSerg
merged 12 commits into
CleverRaven:master
from
Maleclypse:Prepnet-Dialogue-Improvements
Feb 13, 2020
Merged
[Aftershock] Prepnet dialogue and itemgroup fixes #37950
ZhilkinSerg
merged 12 commits into
CleverRaven:master
from
Maleclypse:Prepnet-Dialogue-Improvements
Feb 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catchup to cleverraven
Catchup to CleverRaven
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you have here seems good to me!
This was referenced Feb 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
<Bugfix>
This is a fix for a bug (or closes open issue)
[JSON]
Changes (can be) made in JSON
Mods: Aftershock
Anything to do with the Aftershock mod
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Prepnet dialogue issues and item group fails"
Purpose of change
Fixes to dialogue confusion mentioned by players, and no item spawns attached to some items.
Describe the solution
Added appropriate items to item groups, created new item group, fixed dialogue.
Describe alternatives you've considered
Self immolating from shame.
Testing
Loaded it all up and tested. Seems to work.
Additional context
I'm fine with this fix waiting until 0.E if that helps. That way if it breaks anything past my test build, it doesn't create more work for anyone until the flying vehicles distract people from my failings.