Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -Wmissing-noreturn, and add attributes #38044

Merged
merged 1 commit into from
Feb 16, 2020

Conversation

jbytheway
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

More useful compiler warnings.

Describe the solution

Enable another useful compiler warning. This one helps ensure that functions which don't return are marked thus.

If found a couple of json-related error functions that ought to be marked up.

Also I noticed an old workaround which is no longer necessary thanks to noreturn attributes.

Testing

Compiled and ran unit tests.

Additional context

I sorted the warning options in CMakeLists.txt and Makefile into alphabetical order, except that -Wno-unknown-warning-option is last, because that one is special.

Enable another useful compiler warning.  This one ensures that functions
which don't return are marked thus.

If found a couple of json-related error functions that ought to be
marked up.
@ZhilkinSerg ZhilkinSerg added the Code: Build Issues regarding different builds and build environments label Feb 15, 2020
@ZhilkinSerg ZhilkinSerg merged commit 71ebc26 into CleverRaven:master Feb 16, 2020
fengjixuchui added a commit to fengjixuchui/Cataclysm-DDA that referenced this pull request Feb 16, 2020
Merge pull request CleverRaven#38044 from jbytheway/missing_noreturn
@jbytheway jbytheway deleted the missing_noreturn branch February 16, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Build Issues regarding different builds and build environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants