Add -Wmissing-noreturn, and add attributes #38044
Merged
+9
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
More useful compiler warnings.
Describe the solution
Enable another useful compiler warning. This one helps ensure that functions which don't return are marked thus.
If found a couple of json-related error functions that ought to be marked up.
Also I noticed an old workaround which is no longer necessary thanks to
noreturn
attributes.Testing
Compiled and ran unit tests.
Additional context
I sorted the warning options in
CMakeLists.txt
andMakefile
into alphabetical order, except that-Wno-unknown-warning-option
is last, because that one is special.