Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandon camp fix #37976

Merged
merged 2 commits into from Feb 12, 2020
Merged

Abandon camp fix #37976

merged 2 commits into from Feb 12, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 12, 2020

Summary

SUMMARY: Bugfixes "Abandon camp fix"

Purpose of change

When abandoning camp it used a random NPCs position to pick the submap , when the NPC in question coulda been invalidated by mission returns and stuff, so it sometimes crashed, so instead use the bulletin board position to find the submap to remove the camp.

Describe the solution

As above

Describe alternatives you've considered

N/A

Testing

made camp, abandoned it, no crashy.

Additional context

N/A

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` NPC / Factions NPCs, AI, Speech, Factions, Ownership Player Faction Base / Camp All about the player faction base/camp/site labels Feb 12, 2020
@ZhilkinSerg ZhilkinSerg merged commit b9b3901 into CleverRaven:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` NPC / Factions NPCs, AI, Speech, Factions, Ownership Player Faction Base / Camp All about the player faction base/camp/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant