Weekly Digest (1 December, 2019 - 8 December, 2019) #35955

weekly-digest · 2019-12-08T10:59:11Z

Here's the Weekly Digest for CleverRaven/Cataclysm-DDA:

ISSUES

Last week 153 issues were created.
Of these, 87 issues have been closed and 66 issues are still open.

OPEN ISSUES

CLOSED ISSUES

LIKED ISSUE

👍 #35847 Update evac shelters and bring them (mostly) up to code, by I-am-Erk
It received 👍 x6, 😄 x0, 🎉 x4 and ❤️ x5.

NOISY ISSUE

🔈 #35821 Adds riot control turrets and makes them more common than lethal types. Removes roadblock robots., by I-am-Erk
It received 22 comments.

PULL REQUESTS

Last week, 110 pull requests were created, updated or merged.

OPEN PULL REQUEST

Last week, 1 pull request was opened.
💚 #35948 change avatar::read parameter to item &, by KorGgenT

UPDATED PULL REQUEST

Last week, 39 pull requests were updated.
💛 #35936 Change functions that accept a JsonObject to take that as reference to const., by BevapDin
💛 #35925 Light Manipulation Spellbook, by John-Candlebury
💛 #35924 Add supreme pizza, by HipAndroid
💛 #35921 Leech pod monster family, by John-Candlebury
💛 #35919 [Magiclysm] update black dragon lair, by curstwist
💛 #35888 12ga stocks and brass catcher fixes, by tenmillimaster
💛 #35884 Change most (x)bows to require mod mounts, and add bow-specific mounts, by LaVeyanFiend
💛 #35865 Split 40mm grenade types, by ymber
💛 #35843 Disease infrastructure, by Fris0uman
💛 #35839 Jsonized field description affixes, by ZhilkinSerg
💛 #35830 Jsonized time to atack skill data, by ZhilkinSerg
💛 #35821 Adds riot control turrets and makes them more common than lethal types. Removes roadblock robots., by I-am-Erk
💛 #35818 Refactor defense mode, by ZhilkinSerg
💛 #35805 Update and migrate most Realguns content to core, by Rail-Runner
💛 #35803 Remove "pair of" from singular item names, by Kodiologist
💛 #35792 [WIP] Graphical Overmap update, by Larwck
💛 #35784 Turrets return fire at unseen ranged attackers, by Night-Pryanik
💛 #35782 Implement zone priority, by jagoly
💛 #35778 Limit the kinds of terrain that are vulnerable to mattack::growplants, by Kodiologist
💛 #35759 Weather Tweaks - new light drizzle category and fix wind, by davidpwbrown
💛 #35752 [CR] Update Modular Turrets and Salvaged Robots to match Mainline style and recipes Fixes #35689, by CSHague
💛 #35740 Monster flag usage frequency, by ZhilkinSerg
💛 #35734 Bring EMP grenades in line with reality, by anothersimulacrum
💛 #35711 Partially JSONize dynamic item naming; Give meat dishes new names that display when made with mutant meat, by DaviBones
💛 #35664 refactor game::eat(), by KorGgenT
💛 #35636 Magiclysm brown dragon, by ZhamelSeh
💛 #35630 Incorporate human meat and fat into existing recipes, remove dedicated recipes, by DaviBones
💛 #35522 Aramid armor is like an onion, it has many layers: Kevlar rework, EOD gear and cut-gear., by tenmillimaster
💛 #35272 Adding More Furniture, by WhaleyWhaley
💛 #35242 Remove nuke launch and do some cleanup., by kevingranade
💛 #35239 Advanced inv save settings, by akozhevn
💛 #35238 Added 2 new NPCs., by LovamKicsiGazsii
💛 #35216 Shop rebalance, by crazykiddeath
💛 #35164 More types of alcohol, by Brytenwalda
💛 #35135 NPCs - Free Merchant traders and trader guards , by Brytenwalda
💛 #35121 NPCs - added a new hunter NPC that trades with the player to two locations, by Brytenwalda
💛 #34502 [WIP]advanced_inv refactor, by akozhevn
💛 #34470 Realistic gun cleaning, by misterprimus
💛 #34106 Magiclysm - Dragon Mutation Add-On, by animethecat

MERGED PULL REQUEST

COMMITS

Last week there were 119 commits.
🛠️ [Dragon armor recipes use chiseling quality + move recipe location (#35941) * Dragon armor recipes use chiseling quality

Move black dragon armor recipes to enchanted tab
Fix recipe display for other enchanted subcatergory](49b5702) by LaVeyanFiend
🛠️ locations_commercial.json added; item_groups clean up added locations_commercial.json file in itemgroups folder. Moved multiple lists in item_groups to either locations or locations_commercial by LilShiningMan
🛠️ Fix wrong faction camp starting overmap terrain: When a camp is started in field overmap terrain, the game tries to set up the terrain "faction_base_camp_new_0" (note: the game adds the direction of the existing overmap terrain type, but for fields, that direction is an empty string). However, that overmap terrain does not exist. This commit changes the code to set up the terrain "faction_base_camp_0", which was the value used before a15421ed2be3b49b54ab7b37da5e95f6f35e195b. by BevapDin
🛠️ Add locks as component to assembling a locker Because they give a lock upon disassembling. by BevapDin
🛠️ Disable use of flashbangs on robots Flashbangs could blind and stun turrets and other robots. In real life, flashbangs have no effect on robots. Prevent them from having an effect in game. by anothersimulacrum
🛠️ Jsonized companion skill practice by ZhilkinSerg
🛠️ Merge pull request #35833 from ZhilkinSerg/sa-2019-12-03 Code optimizations reported by static code analysis (2019-12-03) by kevingranade
🛠️ Merge branch 'cardboard-boxes1' of github.com:I-am-Erk/Cataclysm-DDA into cardboard-boxes1 by I-am-Erk
🛠️ forgot can't use shortcuts inside a distribution by I-am-Erk
🛠️ make boxes a little less common by I-am-Erk
🛠️ Update collections_trades.json by I-am-Erk
🛠️ Merge pull request #35880 from Night-Pryanik/bees-field-bugfixes-tweaks Bugfixes and tweaks for fd_bees field by Rivet-the-Zombie
🛠️ Merge pull request #35917 from anothersimulacrum/vita-type Fix Toxins not working with simplified nutrition by ZhilkinSerg
🛠️ [More name, weight, and volume updates (More name, weight, and volume updates #35903) * Update insect_spider.json
Update marloss.json
Update mechsuits.json
Update mi-go.json
Update mutant.json
Update mi-go.json](e0f74b7) by KorGgenT
🛠️ Merge pull request #35911 from KorGgenT/myth-book add norse myth book to itemgroup by ZhilkinSerg
🛠️ Science ID cards as possible drop for zombies scientist (#35890) by Termineitor244
🛠️ Added NOCOLLIDE flag to crafting spots (#35923) by Night-Pryanik
🛠️ Merge pull request #35926 from LilShiningMan/LSM---Tobacco Tobacco Products list added by ZhilkinSerg
🛠️ Add vitamin documentation (#35920) by anothersimulacrum
🛠️ Merge pull request #35922 from curstwist/fix-black-dragon-spawn,-add-overmap_location fix black dragon lair spawn by ZhilkinSerg
🛠️ Tobacco Products list added Added item group "Tobacco Products" and eliminated redundant item entries in various spawn lists by LilShiningMan
🛠️ fix black dragon lair spawn by curstwist
🛠️ [[Magiclysm] Lizardfolk ([Magiclysm] Lizardfolk #35138) * Lizardfolk - main monster file
Lizardfolk - updated base files
Lizardfolk - modified effects file
Lizardfolk - new weapons file
Lizardfolk - new shaman spell file
restore removed harvest entries
lint
change symbols of lizardfolk to L
remove superfluous json members
adjust javelin names
adjust shaman spells
alter shaman drops
adjust lizard folk special attack messages
fix crocodile summoning grammar
adjust lizardfolk descriptions
lizardfolk weapon adjustments
remove superfluous effect](c95dfba) by kmullinax
🛠️ add norse myth book to itemgroup by KorGgenT
🛠️ [Implement iterators for JsonArray: (Implement iterators for JsonArray: #35852) * Rename JsonArray::end member to avoid conflict later
Make some member functions of JsonArray const.
Use size_t instead of int as index value in JsonArray
Implement iterators for JsonArray:

This allows to iterate over a JsonArray with a range-based for loop.

Changes some code to use the form of iterating. This now also works with unnamed JsonArray instances, e.g. for( ... : foo.get_array( ... ) ).

Fix test errors from unvisited JSON object members.

Functions take a copy of the JSON object, so the members in the original object are never visited and that is reported as error.

Fix variable name collision in some compilers.

Yes, I'm looking at you GCC 5.3.1.](f04c6d5) by BevapDin
🛠️ [Further updates evac shelters, adding vandalized and used variants. (#35872) * Add mi-go atmosphere effect

Major evac center update
fix errors caught in play test
minor tweaks
further tweak spawn chances
Adjustments to shelter, add vandalized version to first shelter, change location of basement so stairs align
add bad food vitamin
Update effects.json
Add (currently nonfunctional) bad_food "vitamin" to bars

Will cause a buildup of negative morale if these are all you eat.
For now it's just a warning I guess, until morale effects json is implemented.

Update protein.json
more vandalism
last vandalism
move terminal into chunks so it can be broken
Create shelter_nested.json
Create graffiti.json
Update graffiti.json
Update shelter.json
expand graffiti options
more shelter graffiti
Update shelter.json
Add 'used' variant to shelters
Add "used" SUS for shelters
adjust used locker SUS appearance rate

should be the same as general locker appearance rate

adjust appearance rate of variants, make used the most common
more shelter graffiti](92c284c) by I-am-Erk
🛠️ Appease clang (2019-12-06) (#35891) by ZhilkinSerg
🛠️ [Fixed tools activating for one turn even without charges (Fixed tools activating for one turn even without charges #35896) * Fixed tools activation even without charges
Fixed some more tools](da86792) by Night-Pryanik
🛠️ [Afs Mi-go turrets fix (Afs Mi-go turrets fix #35897) * AFS turret fix
Update afs_bioparts.json
Update afs_deconstruction.json
Update afs_robots.json](cd4fe38) by Maleclypse
🛠️ Merge pull request #35905 from KorGgenT/change-holiday change holiday to christmas by ZhilkinSerg
🛠️ change holiday to christmas by KorGgenT
🛠️ Fix Toxins not working with simplified nutrition This commit adds vitamin types, different variations of vitamins that can later be expanded to have different effects. These are dynamically loaded from JSON into 4 types, vitamin, toxin, drug, and counter. Only vitamin, toxin, and counter are used right now. Only the vitamin type has an effect, used with simplified nutrition to make it so that that vitamin has no effect. by anothersimulacrum
🛠️ [JSONize flag-based modifiers on comestible enjoyability (JSONize flag-based modifiers on comestible enjoyability #35813) * JSONize flag taste modifiers
There was only a single flag that affected the "fun" value of
comestibles (BAD_TASTE) but I want to add more for a water sanitation
rework, so rather than hardcoding more, I JSONized the process.

Adds a new member variable to json_flag objects, "taste_mod," which
additively modifies the enjoyability of comestibles.
This is done via a new function, "item::get_comestible_fun". The MUSHY
flag check was moved there from Character::fun_for as well.
"item::get_comestible_fun" is of course called in "Character::fun_for",
so this commit shouldn't have any functional changes.

Make "islot_comestible::fun" private
Anyone trying to query a comestible's "fun" should be using the new
"item::get_comestible_fun" method. This commit is to enforce that.

Of course, that had to be reconciled with the current usage of "fun".
I added "item" and "Item_factory" as friends of "islot_comestible" so
that "item::get_comestible_fun" and the function that sets "fun" still
have access to it.
All other queries of "fun" were instead changed to the new method.
This has the side-effect of applying BAD_TASTE and MUSHY effects in
places where they didn't before, including but not limited to:

Interaction with taste blocker bionic.
NPCs making decisions about faction food stocks.
NPCs making decisions about whether they personally want food.
Scavenging monsters deciding whether to eat food off the ground.

Apply suggestions from code review

Co-Authored-By: BevapDin [email protected]

Subjugate rogue tab (i.e. astyle)
Fix merge mistake](b1cff02) by DaviBones
🛠️ Merge pull request #35892 from BrettDong/i18n Routine i18n updates on 6 Dec 2019 by ZhilkinSerg
🛠️ Merge pull request #35875 from arijust/flatbread_fix [Aftershock] Modify flatbread recipe by ZhilkinSerg
🛠️ [Raise spawn chance for cardboard boxes. (Raise spawn chance for cardboard boxes. #35876) * Raise chance to get boxes in supplies_hardware.
Raise change for medium_box in mischw group.
Raise chances to get boxes.](4b974f2) by arijust
🛠️ Afs mi go turrets (#35726) by Maleclypse
🛠️ Routine i18n updates on 6 Dec 2019 by BrettDong
🛠️ Updated lang/extract_json_strings.py to recognize "scent_type" JSON type by BrettDong
🛠️ Merge pull request #35842 from ZhilkinSerg/jsonize-skill-companion-rank-factors Jsonize skill companion rank factors by Rivet-the-Zombie
🛠️ Merge pull request #35874 from arijust/fragile_glasses Add fragile flag to majority of glasses. by ZhilkinSerg
🛠️ [add sound/deafness to labels and labels-narrow sidebar layouts (add sound/deafness to labels and labels-narrow sidebar layouts #35886) * add sound/deafness to labels and labels-narrow sidebar layouts
attempt to appease clang-tidy](f25ef50) by esotericist
🛠️ Merge pull request #35877 from CleverRaven/clang-appease-2019-12-05 Appease clang (2019-12-05) by ZhilkinSerg
🛠️ Check for armor coverage Also fixed a bug when bees phase through solid matter by Night-Pryanik
🛠️ Remove redundant get() call on smart pointer by ZhilkinSerg
🛠️ Modify flatbread recipe in Aftershock by arijust
🛠️ Add fragile flag to majority of glasses. by arijust
🛠️ Merge pull request #35873 from DaviBones/laundry-charges Fix resource requirements when washing items with charges by ZhilkinSerg
🛠️ Merge pull request #35869 from DaviBones/horsepower-carry-weight Factor in animal carry weight when determining yoke-and-harness power by ZhilkinSerg
🛠️ Merge pull request #35870 from Kodiologist/high-on-cheese Remove stim values from cheeseburgers etc. by ZhilkinSerg
🛠️ Merge pull request #35871 from Night-Pryanik/mapgen-tweaks-bugfixes Updated road connections to various wilderness locations by ZhilkinSerg
🛠️ Fix items with charges washing bug by DaviBones
🛠️ Updated road connections to various wilderness locations by Night-Pryanik
🛠️ Merge pull request #35864 from sah4001/patch-2 Resolve #35814 by Rivet-the-Zombie
🛠️ Remove stim values from cheeseburgers etc. by Kodiologist
🛠️ [Fix the Dark Sight spell (Fix the Dark Sight spell #35850) * Add Difficulty to Dark Sight

Was originally zero. Justifying the value chosen by the clairvoyance spell, which gives you instantaneous 1 turn vision on all tiles in the aoe based on level. Clairvoyance has difficulty 4. Whereas Dark Sight gives encumbrance-free light amp vision for the same amount of time as a magical light spell. Compared to the Magical Lamp spell which generates regular light at difficulty 2, for the same amount of time. Comparing the distance you gain in vision from light amp, difficulty 6 seems justified.

Add max level and 100 mana cost to Dark Sight

Set it at 20, like every other spell. Made the mana cost equivalent to Magical Light.](d8f47ae) by CSHague
🛠️ Modify animal vehicle power by their strength by DaviBones
🛠️ Fixed sidewalk generation for various buildings (#35853) * Fixed sidewalk generation for city buildings by Night-Pryanik
🛠️ [Update name, volume, and weight json members to newer format (#35857) * update bird.json name, weight, volume

update defense_bot.json name, volume, weight
update drone.json name, abstract
update fish.json name, weight, volume](0ec80bc) by KorGgenT
🛠️ [Updated Android build process (2019-12-04) (Updated Android build process (2019-12-04) #35859) * Fix typo
Add experimental product flavor](b01285b) by ZhilkinSerg
🛠️ Merge pull request #35862 from sah4001/patch-1 Resolve #35858 by ZhilkinSerg
🛠️ Merge pull request #35866 from tenmillimaster/tube-mag-fixes Tube magazine fixes by ZhilkinSerg
🛠️ Update shot.json by tenmillimaster
🛠️ Linting by sah4001
🛠️ resolve #35814 added Brioche where it makes sense as an ingredient by sah4001
🛠️ Resolve #35858 Make FEMA evacuation pamphlet "looks_like": "newest_newspaper" instead "newspaper" by sah4001
🛠️ Merge pull request #35851 from OzoneH3/book_sort_fix Very small typo fix by ZhilkinSerg
🛠️ Fix typo by OzoneH3
🛠️ Merge pull request #35829 from Fris0uman/para_milk Removes parasites from raw_milk by Rivet-the-Zombie
🛠️ [Rope and cordage overhaul (Rope and cordage overhaul #35700) * Rope and cordage overhaul
Add extra comments about weight/length](172f04f) by Rail-Runner
🛠️ [New JSON recipe property for overriding inheritance of specified flags (New JSON recipe property for overriding inheritance of specified flags #35825) * Add JSON field to delete flags in recipes
My initial incarnation of flag inheritance included an item flag that
completely disabled flag inheritance when that item was crafted.
In retrospect, that was a poor solution. It is too heavy-handed in
practice. For instance, it doesn't allow recipes to inherit one flag as
normal, while removing another. This solution should be more practical.
Remove obsolete NO_CRAFT_INHERIT flag
The new "delete_flags" property of recipes does everything it used to do
and more.
Also replaced all uses of NO_CRAFT_INHERIT with delete_flags property.
Change flags_to_delete from vector to set
As suggested by BevapDin.](9f74eae) by DaviBones
🛠️ Update evac shelters and bring them (mostly) up to code (#35847) by I-am-Erk
🛠️ Restore penalty to reading already-read books. (#35845) by kevingranade
🛠️ [Remove professions with survivor armor & change Rescuer's armor (Remove professions with survivor armor & change Rescuer's armor #35844) * Remove professions with survivor armor, change Rescuer to fur armor
Remove obsoleted profs from scenario options
Obsolete collections, give rescuer utility vest for magazines](b40b704) by LaVeyanFiend
🛠️ Silence type punning warning reported by gcc 6.5 (#35849) by kevingranade
🛠️ Jsonize skill companion rank factors by ZhilkinSerg
🛠️ Butter from raw milk and butter churn (#34854) by Maleclypse
🛠️ Merge pull request #35834 from CleverRaven/fix-magiclysm-region-overlay Fix region overlay in Magiclysm mod by ZhilkinSerg
🛠️ Max_volume for terrain and furniture can be defined with strings (#35823) by Fris0uman
🛠️ [Make batteries more standardized (Make batteries more standardized #35827) * Make batteries more standardized
Adjust Foodperson mask to last one shift

The install time for all other gunmods is commented out, it doesn't
appear to work right now.

One description was missing a space.

Add an uncomfortable grip gunmod and have it installed by default on the
remington 870 MCS, instead of the handling modifier which does not work.

Update blazemod for shotguns
Fix speedloaders

Done at the request of tenmillimaster

Remove dead reference to l_def_12 in no rivtech
Fix shotgun tests](689a417) by anothersimulacrum
🛠️ add cabin roofs (#35798) by curstwist
🛠️ [Rescuer brings a magazine & uses their harness (Rescuer brings a magazine & uses their harness #35810) * Rescuer brings a magazine
Rescuer uses their harness](e496f3b) by LaVeyanFiend
🛠️ [Monster/pet carry weight changed to 1/5th of body weight (Monster/pet carry weight changed to 1/5th of body weight #35807) * Make monster carry weight 1/5th of body weight
Previously, carry weight calculation for monsters was the same as for
humans, using a 5 tier size system, where monsters were placed in tiers
based on their weight. This caused a few problems:

Tier 5 too small in some cases (e.g. cows could only carry 52 kg)
Tier 1 too big in some cases (e.g. chickens carrying 3x body weight)
Tiers too granular; increase of a single kg could double carry weight

Use existing member variable instead of literal

Co-Authored-By: anothersimulacrum [email protected]](c071ede) by DaviBones
🛠️ Merge pull request #35811 from anothersimulacrum/speedloader Fix typo in speedloader description by ZhilkinSerg
🛠️ Fix typo by anothersimulacrum
🛠️ Merge pull request #35754 from ZhilkinSerg/refactor-map-point-functions-2019-11-28 Cleanup point-related code by Rivet-the-Zombie
🛠️ I know now why you cry: Shotgun additions (#34638) by tenmillimaster
🛠️ Merge pull request #35796 from anothersimulacrum/no-freeze-stale Prevent stalebot from stale-ing PRs in feature freeze. by ZhilkinSerg
🛠️ [Fix for incompatible magazine spawning in national guard camp (#35794) * scarhmag -> stanag30

Correct magazine inside gun.

Fix for using gasoline as flamethrower ammo](54572ca) by hfox

CONTRIBUTORS

Last week there were 28 contributors.
👤 LaVeyanFiend
👤 LilShiningMan
👤 BevapDin
👤 anothersimulacrum
👤 ZhilkinSerg
👤 kevingranade
👤 I-am-Erk
👤 Rivet-the-Zombie
👤 KorGgenT
👤 Termineitor244
👤 Night-Pryanik
👤 curstwist
👤 kmullinax
👤 Maleclypse
👤 DaviBones
👤 arijust
👤 BrettDong
👤 esotericist
👤 Kodiologist
👤 CSHague
👤 tenmillimaster
👤 sah4001
👤 OzoneH3
👤 Rail-Runner
👤 Fris0uman
👤 AlexMooney
👤 davidpwbrown
👤 hfox

STARGAZERS

Last week there were 14 stagazers.
⭐ micheldmolinari
⭐ Dexyne
⭐ MrBBBaiXue
⭐ wetstreet
⭐ lukemcraig
⭐ ArseneJi
⭐ claireis
⭐ tinukedaya
⭐ wycaca
⭐ Termineitor244
⭐ Capster
⭐ hyll8882019
⭐ Mirageghanastar
⭐ spoutnickgp
You all are the stars! 🌟

RELEASES

That's all for last week, please 👀 Watch and ⭐ Star the repository CleverRaven/Cataclysm-DDA to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

The text was updated successfully, but these errors were encountered:

RickyVanz · 2019-12-08T12:19:47Z

whoo~ big work, big changes..

love it.

weekly-digest bot added the weekly-digest label Dec 8, 2019

kevingranade closed this as completed Dec 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Weekly Digest (1 December, 2019 - 8 December, 2019) #35955

Weekly Digest (1 December, 2019 - 8 December, 2019) #35955

weekly-digest bot commented Dec 8, 2019

RickyVanz commented Dec 8, 2019

Weekly Digest (1 December, 2019 - 8 December, 2019) #35955

Weekly Digest (1 December, 2019 - 8 December, 2019) #35955

Comments

weekly-digest bot commented Dec 8, 2019

ISSUES

OPEN ISSUES

CLOSED ISSUES

LIKED ISSUE

NOISY ISSUE

PULL REQUESTS

OPEN PULL REQUEST

UPDATED PULL REQUEST

MERGED PULL REQUEST

COMMITS

CONTRIBUTORS

STARGAZERS

RELEASES

RickyVanz commented Dec 8, 2019