-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "pair of" from singular item names #35803
Conversation
Oh dang, this doesn't work quite as I hoped; three pairs of boots are now listed in the inventory as "3 boots", which is pretty confusing. Perhaps the plural forms should retain "pairs of", while the singular forms should have no "pair of"? (That's what I did in Rogue TV, back when I was actually working on that game.) What do you guys think? |
Not a huge fan of that solution either.
I do agree that some of the item names in question are too long (e.g. |
|
That isn't my complaint, I agree that the description stating that the item comes in pairs is sufficient, just like stating that the M4A1 is a carbine in the description is sufficient. My complaint is with the ambiguity of the number of pairs present in the singular case. Yes,
but your proposed change might throw that concept into question for players still learning the game. |
I have now pushed a new version that does what I just described. And now I notice that "the number is omitted for a single unit of an item" is not actually true throughout the game. You can get the messages "You see here 1 boots", "You see here 1 blueberries", and "You see here 1 SPAM". I suspect that deeper changes are needed to make the game more grammatically aware, and the interaction of that with translation will be a nasty business. I'd say that on balance this change is probably for the better, but clearly it's a judgment call. |
yeah it seems fine as it is to me boss, don't see why this needs changing, goes to a more confusing en result so far |
I gave this some time for a good think over and I agree, while the motivation behind this is great, the result is just too awkward. |
Summary
SUMMARY: Interface "Remove \"pair of\" from item names"
Purpose of change
To remove uninformative prefixes, as in #34977.
Describe the solution
It's a big diff for one small change: a regex replacement from
"name": "(?:pair of )?(.+?)",\s+"name_plural": "pairs of .+?"
to"name": { "str": "\1", "str_pl": "\1" }
.Describe alternatives you've considered
Perhaps some items whose pairing is not obvious, like butterfly knives, should keep the "pair of".
Items with singular and plural names that are identical are common enough that there should be a way to specify them without repeating the name (e.g.,
"name": { "str_ps": "knitting needles" }
). The current system is just begging for duplicated names to get accidentally desynchronized. But perhaps that's better left for another PR.