Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "handful" and "serving" from item names #34977

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

Kodiologist
Copy link
Contributor

Summary

SUMMARY: BALANCE "Remove \"handful\" and \"serving\" from item names"

Purpose of change

These prefixes make item names longer and don't seem to provide any information to the reader. Because they're prefixes rather than suffixes, the main part of the item name gets cut off in preference to them when there isn't room for the whole name.

Describe the solution

I removed the prefixes. I kept each name_plural, duplicating the respective name, so the game doesn't attempt to pluralize e.g. "blueberries" into "blueberrieses".

Additional context

See the discussion in #29074.

@KorGgenT
Copy link
Member

while you're changing names, you could update it to the new format "name": { "str": "goose", "str_pl": "geese" }

@Kodiologist
Copy link
Contributor Author

@KorGgenT Done.

@KorGgenT
Copy link
Member

@Kodiologist
Copy link
Contributor Author

@KorGgenT Done.

@ZhilkinSerg ZhilkinSerg added Items / Item Actions / Item Qualities Items and how they work and interact Translation I18n [JSON] Changes (can be) made in JSON labels Oct 24, 2019
@dunstad
Copy link
Contributor

dunstad commented Oct 25, 2019

As someone who regularly plays on a tiny screen I really appreciate this!

@ZhilkinSerg ZhilkinSerg merged commit 8ca757d into CleverRaven:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants