Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monster/pet carry weight changed to 1/5th of body weight #35807

Merged
merged 2 commits into from
Dec 2, 2019

Conversation

Davi-DeGanne
Copy link
Contributor

Summary

SUMMARY: Balance "Monster/pet carry weight changed to 1/5th of body weight"

Purpose of change

Previously, carry weight calculation for monsters was the same as for
humans, using a 5 tier size system, where monsters were placed in tiers
based on their weight. This caused a few problems:

  • Tier 5 too small in some cases (e.g. cows could only carry 52 kg)
  • Tier 1 too big in some cases (e.g. chickens carrying 3x body weight)
  • Tiers not granular enough; increase of a single kg could double carry weight

Describe the solution

Safe weight capacity of animals seems to be about 20% - 25% of their body weight. I went with 20%, for no reason in particular other than it being the more conservative estimate.

Describe alternatives you've considered

Making higher load weights possible, but only for limited duration. Seems like a lot of work for a feature most people likely would never use.

Testing

Additional context

Previously, carry weight calculation for monsters was the same as for
humans, using a 5 tier size system, where monsters were placed in tiers
based on their weight. This caused a few problems:

- Tier 5 too small in some cases (e.g. cows could only carry 52 kg)
- Tier 1 too big in some cases (e.g. chickens carrying 3x body weight)
- Tiers too granular; increase of a single kg could double carry weight
src/monster.cpp Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Dec 1, 2019

This also has the benefit of bringing it in line with the max weight a horse can carry when the player tries to mount them.

I put that at 1/5th the animals weight as the limit there too, so its good itll be consistent now.

As you say - 1/5th is not the perfect solution as they could carry more weight for shorter periods, but itl do for the moment until we have animal stamina and caring / feeding your packmule/mount etc.

@Fris0uman
Copy link
Contributor

Could this be somewhat jsonized? So that for exemple animals get the 1/5 ratio by default but you could override it to make stronger monsters?

@anothersimulacrum
Copy link
Member

anothersimulacrum commented Dec 2, 2019

That's what the suggestion I made (and was comitted) does.
By default everything will be 20%, but any monster with a mountable weight ration will use that instead.

@Davi-DeGanne
Copy link
Contributor Author

Checked the CI failure, seems unrelated to my changes. Let me know if I missed something.

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. Monsters Monsters both friendly and unfriendly. labels Dec 2, 2019
@ZhilkinSerg ZhilkinSerg merged commit c071ede into CleverRaven:master Dec 2, 2019
@Davi-DeGanne Davi-DeGanne deleted the pack-animal-capacity branch December 2, 2019 03:59
@yowshi
Copy link
Contributor

yowshi commented Dec 12, 2019

ok i am fairly certain that horses should be able to carry a personm + more then 40kg's at this point i am now at below 35 Kg carry weight and i still can't mount a horse. this is rediculus as horses and cows are now useless as m,ounts.

@Davi-DeGanne
Copy link
Contributor Author

You are in the wrong place. This PR buffed horse max inventory weight substantially. And it didn't touch their maximum rider weight at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants