-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor defense mode #35818
Merged
kevingranade
merged 9 commits into
CleverRaven:master
from
ZhilkinSerg:refactor-defense-mode
Dec 17, 2019
Merged
Refactor defense mode #35818
kevingranade
merged 9 commits into
CleverRaven:master
from
ZhilkinSerg:refactor-defense-mode
Dec 17, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ea7eba
to
c4f069e
Compare
BevapDin
reviewed
Dec 2, 2019
BevapDin
reviewed
Dec 2, 2019
BevapDin
reviewed
Dec 2, 2019
ZhilkinSerg
commented
Dec 4, 2019
ZhilkinSerg
commented
Dec 4, 2019
26093c9
to
4deabb6
Compare
ZhilkinSerg
commented
Dec 5, 2019
ZhilkinSerg
commented
Dec 5, 2019
70c1f4e
to
0b3e068
Compare
0b3e068
to
314c1fb
Compare
Minimum size of the box that can contain whole overmap special
314c1fb
to
bb32a0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[C++]
Changes (can be) made in C++. Previously named `Code`
Code: Infrastructure / Style / Static Analysis
Code internal infrastructure and style
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Refactor defense mode"
Purpose of change
Defense mode needs some love. I've made some internal code refactor to simplify future changes.
Describe the solution
See commit messages.
Testing
Start game in defense mode, see updated menu.
Additional context
Future updates will follow eventually.
Screenshots
** Defense mode setup menu (before) **

** Defense mode setup menu (after) **