Weekly Digest (8 December, 2019 - 15 December, 2019) #36128

Those functions do not change the object, they just read values from it. This avoid unnecessary copy-operations and allows usage of temporary objects (which don't bind to non-const references).

Remove unnecessary calls to JsonObject::allow_omitted_members
Fix build for cata_tiles.cpp
Fix JSON object member being unvisited
Fix potential nullpointer access in JSON classes:

Error reporting functions are public and can be called on any object, even on those that do not have an associated stream.](604b633) by BevapDin
🛠️ Merge pull request #35967 from BevapDin/lws Fix unloading liquid into same container by ZhilkinSerg
🛠️ Merge pull request #35982 from BevapDin/sgp Add PRIMITIVE_RANGED_WEAPON to compound bows so they don't accumulate dirt and won't need mending. by ZhilkinSerg
🛠️ Add PRIMITIVE_RANGED_WEAPON to compound bows so they don't accumulate dirt and won't need mending. by BevapDin
🛠️ Merge pull request #35961 from arijust/handmade_carbines Modify existing handmade carbines by Rivet-the-Zombie
🛠️ Merge pull request #35974 from DaviBones/fix-errant-periods Remove a couple of redundant periods by ZhilkinSerg
🛠️ Syntax fix by kevingranade
🛠️ Limit the kinds of terrain that are vulnerable to mattack::growplants by Kodiologist
🛠️ Remove a couple of redundant periods by DaviBones
🛠️ Refactor monster movement flag checks (#35776) by ZhilkinSerg
🛠️ [Refactor monster regeneration flags (#35775) * Refactor REGENERATES_X monster flags into number property

Refactor REGENERATES_IN_DARK monster flag into boolean property
Refactor REGEN_MORALE monster flag into boolean property
Apply suggestions from code review

Co-Authored-By: BevapDin [email protected]](a8e29c6) by kevingranade
🛠️ Weather Tweaks - new light drizzle category and fix wind (#35759) by davidpwbrown
🛠️ Added gathering of monster flag usage statistics (#35740) by kevingranade
🛠️ [Bring EMP grenades in line with reality (#35734) * Bring EMP grenades in line with reality

Right now, EMP grenades are somewhat nonsense - they can be crafted out
of some electronic scrap, yet easily take down any robotic enemy. These
are problematic not just from their ease of crafting - they also help to
trivialize robotic enemies.

This commit aims to change the that, by replacing the EMP grenade recipe
with one based off of real-life EMP weapons.
This EMP device works by draining a high-current capacitor (represented
by a plutonium fuel cell) into a 'explosively propelled flux compression
generator'. When this generator is activated, with the aid of an
explosion, it creates a strong magnetic field. This magnetic field is
then passed through a microwave generator (magnetron), into a single
loop antenna, which creates the EMP.

I have created a new uncraftable emp grenade which functions like the
current, but is uncraftable and can only be obtained through military
drops rarely, or more commonly from Hub 01.
I have also obsoleted the recipe for the scrambler grenade, because it
similarly did not make much sense. Hub 01 will generally be the supplier
of these.

I have added a large copper tube, magnetron, and flux compression
generator as necessary components for crafting devices introduced in
this PR.
The tube and flux compression generator have had crafting recipes added.

I have largely replaced the former EMP grenade, that is now an EMP bomb,
with EMP grenades. Particularly in the inventory of Hub 01 NPCs, because
that could get deadly.

I have added the flux compression generator to one itemgroup.
The magnetron appears in none (you can get it from microwaves though).
The large copper tube does not spawn and can only be forged.
Perhaps this could be improved

Adjust EMP explosive power, remove some recipes

Remove the large copper tube completely and the flux compression
generator recipe.

The flux compression generator requires fiberglass to be craftable,
which is more of a hurdle than I initially considered.

The large copper tube was only used in crafting it, and is no longer
needed.

I also recalculated the volume/weight/etc of the flux compression
generator and found that I could get away with much lower explosive
power, so I've lowered it, and removed the explosion fudging.](b6e17ea) by anothersimulacrum
🛠️ Give NPCs the handicap bonus to use out of LOS welding rigs for vehicle repair (#35687) * give NPCs the handicap bonus to use out of LOS welding rigs by davidpwbrown
🛠️ [Realistic gun cleaning (#34470) * Update faults_gun.json

main
lint
Update faults_gun.json
Update data/json/items/gun/faults_gun.json

Co-Authored-By: Anton Burmistrov [email protected]

laser weapons should not foul
lint
lighten requirements
Update faults_gun.json
Update faults_gun.json
various

-add motor oil
-expand out ways to clean gun
-gun can be cleaned at same time as lubing, increasing efficiency (time) of the processes
-various other tweaks

Update data/json/items/fuel.json

Co-Authored-By: Anton Burmistrov [email protected]

merge conflicts
Update ranged.cpp
various tweaks

Reduced cleaning time by a bit.

Pipe cleaner no longer requires rag/fur to craft.

Cleaning actions now require rag/fur to clean.

Regular gunpowder fouling is now capped a bit. Gun will no longer accumulate dirt to the point of effectively seizing and "blowing up" all the time, except if you use black gunpowder.

If your gun gets really dirty (now only possible with blackpowder ammunition or unlucky zed drop), you will get a message to unload and reload your gun. It will take longer, as the fouling will prevent the mags/cartridges from extracting easily, but you will experience a drop in dirt. This requires no tools and is quite quick compared to a full cleaning action.

Update faults_gun.json
Update faults_gun.json
proportions
Update faults_gun.json
Update faults_gun.json
various, see description

rename procedure to fault
remove combo procedure from mend menu
add fault replacement system
add flags system to faults (for silence of fouling "faults")

fixed error
Update faults_gun.json
final changes
Update src/player_activity.h

Co-Authored-By: Jianxiang Wang (王健翔) [email protected]

Update src/ranged.cpp

Co-Authored-By: Jianxiang Wang (王健翔) [email protected]

Update src/ranged.cpp

Co-Authored-By: Jianxiang Wang (王健翔) [email protected]

guns with highly limited moving parts don't meed lubrication
Update data/json/items/gun/faults_gun.json

Co-Authored-By: Jianxiang Wang (王健翔) [email protected]

Update src/activity_handlers.cpp

Co-Authored-By: BevapDin [email protected]

comments
Update src/item_group.cpp

Co-Authored-By: anothersimulacrum [email protected]

Update src/item_group.cpp

Co-Authored-By: anothersimulacrum [email protected]

Update src/item_group.cpp

Co-Authored-By: anothersimulacrum [email protected]

comments
comments
Update ranged.cpp
dirt ranges
static cast](0d9d764) by kevingranade
🛠️ Fix redundant messages for player speech by DaviBones
🛠️ Fix NPC head explodey when they leave / reenter reality bubble with an activity (#35649) by davidpwbrown
🛠️ [Fixed "Vehicle disappearing when grabbing another veh inside" (Fixed "Vehicle disappearing when grabbing another veh inside" #35641) * Specify vehicle in displace_vehicle
Fix the loop breaking
Changed displace_vehicle to use vehicle reference .
Removed global vehicle position parameter.
Astyle for tests folder.](576881f) by ipcyborg
🛠️ [Incorporate human meat and fat into existing recipes, remove dedicated recipes (Incorporate human meat and fat into existing recipes, remove dedicated recipes #35630) * JSONize dynamic naming
To allow for items to be given different names depending on the context,
done via a JSON property, reducing the need for both highly similar item
definitions, and some hardcoded dynamic naming systems.
Partially dehardcode corpse naming
Proof of concept for FLAG-based contextual names.
Makes "skinned", "field-dressed", and "quartered" qualifiers defined by
a contextual_names property on the corpse JSON definition.
Change meat dishes' names when mutant meat is used
Proof of concept for COMPONENT_ID-based contextual names.
Add string extraction for conditional names
Rewrite corpse naming
Before, they were long and cumbersome. I was able to reorganize the code
to output far more concise names.
Revise conditional naming documentation
The example was a bit contrived, this one is more applicable while still
covering all the bases.
Additionally, I added a short paragraph warning about automatic
pluralization, to hopefully help others avoid the pitfall I fell into.
Touch-up protein drink/powder conditional names
perturbing pelmeni -> perilous pelmeni
To free up perturbing for:
unpalatable protein powder -> perturbing protein powder
Because unpalatable sounded weird and wasn't alliterative enough.
Also, gave protein drink/shakes the same names, they had none before.
Make CANNIBALISM flag inheritable
The CANNIBALISM flag is already automatically added to food with the
"hflesh" material. This makes it inheritable, paving the way for use in
recipes as an alternative to normal meat while correctly passing on its
negative effects.](489b861) by DaviBones
🛠️ [Shop rebalance (Shop rebalance #35216) * Rebalance Shops
other shop changes
Phamacy rebalance
Update data/json/mapgen/s_gun.json

Co-Authored-By: Kevin Granade [email protected]

Update data/json/mapgen/s_gun.json

Co-Authored-By: Kevin Granade [email protected]

Update s_gun.json
Update homeimprovement_superstore_new.json](421fa21) by kevingranade
🛠️ More types of alcohol (#35164) by Brytenwalda
🛠️ Detect when unloading liquid into the same container. This works even when the caller does not provide the container item as pointer for the function. by BevapDin
🛠️ Merge pull request #35962 from Fris0uman/modulfix Fix modular Turret error on load by ZhilkinSerg
🛠️ [[Magiclysm] release black dragon lair ([Magiclysm] update black dragon lair #35919) * update black dragon lair

add lizard folk spawns, some ground level improvements.

update dragon
Update data/mods/Magiclysm/monstergroups.json

Co-Authored-By: Curtis Merrill [email protected]

update lair loot for treasure rooms
fix item group name](636df0a) by curstwist
🛠️ item_groups sorting sorted more item groups into proper .jsons by LilShiningMan
🛠️ Fix modular Turret error on load by Fris0uman
🛠️ Tweak recipes for surv_carbine_223 and rifle_308. by arijust
🛠️ Rename pipe rifle .308 by arijust
🛠️ Merge pull request #35958 from Fris0uman/afterfix Fix afterschock error on load by ZhilkinSerg
🛠️ Fix afterschock error on load by Fris0uman
🛠️ Avoid double map lookup by jbytheway
🛠️ Added test for the effect of tapeworm on calories by jbytheway
🛠️ Rewrite compute_default_effective_vitamins This function was unnecessarily messy for no particularly good reason. by jbytheway
🛠️ Introduce new nutrients struct Add a new nutrients struct, which consists of some calorie and vitamin info. Use this struct in food item definitions (specifically, islot_comestible) and in stomach. Turned out stomach already contained a nutrients struct, which contained the above together with water and total volume. That is renamed food_summary, and uses nutrients internally. The main advantage of this separate struct is that it simplifies the arithmetic used to compute aggregate food nutrient values based on components used to craft that food. That code was also refactored and split up to make it easier to understand and helps separate out the things which will need to be separate to work on #28180. The only intended observable behaviour change from this commit is that tapeworms now consume half of the calories you ingest, as well as half the vitamins (they used to only affect vitamins). by jbytheway
🛠️ Tweak starve_test - Ensure the test doesn't run forever. - Make the test actually do something. - Update expected_day to match current behaviour. by jbytheway
🛠️ [Document how to build and run the custom clang-tidy checks on Windows (Document how to build and run the custom clang-tidy checks on Windows #35455) * Document how to build and run the custom clang-tidy checks on Windows
Apply suggestions from code review

Co-Authored-By: Anton Burmistrov [email protected]

Update instructions](6ffa818) by ZhilkinSerg
🛠️ Further expand regional terrains and work them into some map palettes (#35836) by I-am-Erk
🛠️ [Added hints for New Game modes (Added hints for New Game modes #35927) * Added hints for New Game modes
Translation stuff](c42d4ea) by Night-Pryanik
🛠️ [Reorganize SUS itemgroups (Reorganize SUS itemgroups #35932) * Reorganize SUS itemgroups
Rename house SUS file](6b00ffc) by ymber
🛠️ [some extra lizardfolk fixes (some extra lizardfolk fixes #35935) * adjust lizardfolk hunter gun
remove superfluous members
remove superfluous body parts from gun](b5605c9) by KorGgenT
🛠️ Merge pull request #35944 from LilShiningMan/LSM---Location_commercial locations_commercial.json added; item_groups clean up by ZhilkinSerg
🛠️ Merge pull request #35950 from Jerimee/patch-1 m edit of novel_erotic desc by ZhilkinSerg
🛠️ Merge pull request #35952 from Jerimee/patch-2 m by ZhilkinSerg
🛠️ Update instructions by Qrox
🛠️ Apply suggestions from code review Co-Authored-By: Anton Burmistrov [email protected] by Qrox
🛠️ Document how to build and run the custom clang-tidy checks on Windows by Qrox
🛠️ Merge pull request #35928 from I-am-Erk/cardboard-boxes1 Put some stuff into boxes by Rivet-the-Zombie
🛠️ m by Jerimee
🛠️ m edit of novel_erotic desc Change "Hackneyed narrative concealing low-grade literary smut." to "A hackneyed fictional narrative concealing low-grade literary smut." in keeping with book convention by Jerimee

CONTRIBUTORS

Last week there were 42 contributors.
👤 arijust
👤 Hymore246
👤 ZhilkinSerg
👤 Jerimee
👤 BevapDin
👤 ymber
👤 Qrox
👤 Rivet-the-Zombie
👤 LaVeyanFiend
👤 kevingranade
👤 misterprimus
👤 I-am-Erk
👤 Night-Pryanik
👤 BrettDong
👤 ishtatann
👤 KorGgenT
👤 Maleclypse
👤 CountAlex
👤 AMurkin
👤 mark7
👤 DaviBones
👤 AlexMooney
👤 LilShiningMan
👤 ifreund
👤 Lys3rg1k
👤 ralreegorganon
👤 cainiaowu
👤 Ramza13
👤 CSHague
👤 HipAndroid
👤 Fris0uman
👤 curstwist
👤 8street
👤 Jovus
👤 tenmillimaster
👤 Rail-Runner
👤 Kodiologist
👤 davidpwbrown
👤 anothersimulacrum
👤 ipcyborg
👤 Brytenwalda
👤 jbytheway

STARGAZERS

Last week there were 21 stagazers.
⭐ Jerimee
⭐ jordan9001
⭐ eerohele
⭐ Fingell
⭐ anatolbran
⭐ hlah
⭐ Djeeberjr
⭐ RafeHaab
⭐ Jovus
⭐ mikelei8291
⭐ AlexanderBodnya
⭐ illumiMatii
⭐ blake8090
⭐ namkazt
⭐ bigbang20061
⭐ OtpalTS
⭐ aclink918ruby
⭐ xhebox
⭐ wuxinxin544
⭐ zappedfish
⭐ JimmyCalamity
You all are the stars! 🌟

RELEASES

That's all for last week, please 👀 Watch and ⭐ Star the repository CleverRaven/Cataclysm-DDA to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

The text was updated successfully, but these errors were encountered:

weekly-digest bot added the weekly-digest label Dec 15, 2019

kevingranade closed this as completed Dec 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Weekly Digest (8 December, 2019 - 15 December, 2019) #36128

Weekly Digest (8 December, 2019 - 15 December, 2019) #36128

weekly-digest bot commented Dec 15, 2019

Weekly Digest (8 December, 2019 - 15 December, 2019) #36128

Weekly Digest (8 December, 2019 - 15 December, 2019) #36128

Comments

weekly-digest bot commented Dec 15, 2019

ISSUES

OPEN ISSUES

CLOSED ISSUES

LIKED ISSUE

NOISY ISSUE

PULL REQUESTS

OPEN PULL REQUEST

UPDATED PULL REQUEST

MERGED PULL REQUEST

COMMITS

CONTRIBUTORS

STARGAZERS

RELEASES