-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Aftershock] Atomic churn pseudo tool and deconstruct #35975
Merged
ZhilkinSerg
merged 13 commits into
CleverRaven:master
from
Maleclypse:Aftershock-Atomic-Churn-Pseudo-tool
Dec 13, 2019
Merged
[Aftershock] Atomic churn pseudo tool and deconstruct #35975
ZhilkinSerg
merged 13 commits into
CleverRaven:master
from
Maleclypse:Aftershock-Atomic-Churn-Pseudo-tool
Dec 13, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catching up to current version
Catchup to current mainline
catchup to current baseline
Catch up to main
Catchup to Master
ZhilkinSerg
reviewed
Dec 11, 2019
Co-Authored-By: ZhilkinSerg <[email protected]>
BevapDin
reviewed
Dec 11, 2019
…com/Maleclypse/Cataclysm-DDA into Aftershock-Atomic-Churn-Pseudo-tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
Mods: Aftershock
Anything to do with the Aftershock mod
Mods
Issues related to mods or modding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Atomic Churn missing pseudo tool and deconstruct"
Purpose of change
There was no way to undeploy the Atomic Churn and it also didn't function once it was full of milk as a churn.
Describe the solution
Added in the pseudo that was described but never implemented and added in the easy deconstruct flag and deconstruct.
Describe alternatives you've considered
Making it's deployment a permanent act of nuclear domination
Testing
Ran this through it's paces. Spawning in deploying, making butter then deconstructing.
Additional context
It previously could churn milk in it's presence but not inside it into butter, which was a little too sci-fi for Aftershock.