Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Causes cardboard boxes to spawn more often along with item groups, rather than as an item *in* the group."
Purpose of change
#35876 closes #35795 but in a way I think is a bit unsatisfactory. The issue is that lists like
mischw
are distributions, which are zero-sum item spawning lists. If a cardboard box spawns in that list, it means actual useful hardware doesn't, and since those lists are generally used where we want content rather than junk to spawn, I was reluctant to flat bump-up spawning like that.Describe the solution
distribution
is a zero-sum spawn list, butcollection
is not. What we really want here is formischw
and similar supply lists to have a chance of spawning container items like cardboard, and a chance to spawn useful stuff. This has the side benefit of making it seem like these items are spawning 'in' the cardboard box, at least until such time as we have rational containers.Describe alternatives you've considered
I briefly considered entirely rebalancing the lists to use a mix of collections and distributions more intelligently, but these lists are too general purpose for such a profound rebalance. What we really need is more Specific Use Storage groups for hardware stores and things.
Testing
Go in game, check the mischw itemgroup, see that it spawns cardboard boxes and large cardboard boxes a lot. It does. Cool.
Additional context
This is a demonstration currently. I could add more or leave it to others like @arijust to learn how to do this and expand the concept.