Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put some stuff into boxes #35928

Merged
merged 4 commits into from
Dec 8, 2019

Conversation

I-am-Erk
Copy link
Member

@I-am-Erk I-am-Erk commented Dec 7, 2019

Summary

SUMMARY: Content "Causes cardboard boxes to spawn more often along with item groups, rather than as an item *in* the group."

Purpose of change

#35876 closes #35795 but in a way I think is a bit unsatisfactory. The issue is that lists like mischw are distributions, which are zero-sum item spawning lists. If a cardboard box spawns in that list, it means actual useful hardware doesn't, and since those lists are generally used where we want content rather than junk to spawn, I was reluctant to flat bump-up spawning like that.

Describe the solution

distribution is a zero-sum spawn list, but collection is not. What we really want here is for mischw and similar supply lists to have a chance of spawning container items like cardboard, and a chance to spawn useful stuff. This has the side benefit of making it seem like these items are spawning 'in' the cardboard box, at least until such time as we have rational containers.

Describe alternatives you've considered

I briefly considered entirely rebalancing the lists to use a mix of collections and distributions more intelligently, but these lists are too general purpose for such a profound rebalance. What we really need is more Specific Use Storage groups for hardware stores and things.

Testing

Go in game, check the mischw itemgroup, see that it spawns cardboard boxes and large cardboard boxes a lot. It does. Cool.

Additional context

This is a demonstration currently. I could add more or leave it to others like @arijust to learn how to do this and expand the concept.

@I-am-Erk I-am-Erk added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map labels Dec 7, 2019
@tenmillimaster
Copy link
Member

♪Put your stuff in the box... ♬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Normal" cardboard boxes are absurdly rare
3 participants