Raise spawn chance for cardboard boxes.

[arijust]

Summary

SUMMARY: Balance "Raise spawn chance for cardboard boxes."

Purpose of change

Close #35795

Describe the solution

Tweak probability to get boxes in several item groups.

Describe alternatives you've considered

Raise spawn chances a bit more and make some items spawn in medium boxes.

[I-am-Erk]

Glad to see someone else giving cardboard a little love.

For the non-trash item groups, like hardware, you want to make boxes into a separate collection that can appear alongside other goods. Otherwise all you're doing is increasing the chance that instead of a useful item, the player just finds an empty cardboard box, effectively just decreasing the spawn of tools and things in favour of cardboard. Dino Dave would approve, but I don't think it's what you're going for.

I'll show you what I mean as soon as I'm off my phone. Collections are a powerful tool for making our item groups smarter, and we need more people to start using them on projects like this.

[SpellingSword]

Thanks :)

[I-am-Erk]

@ZhilkinSerg I was kinda in the midst of suggesting changes there...

[I-am-Erk]

So @arijust I can go do it in a separate pr, but if you'd like to learn to adjust this stuff let me know either here or on the discord. It's not incredibly difficult.

Basically the code looks like this

{
        "collection": [
          { "item": "plastic_spoon", "count": [ 0, 6 ] },
          { "item": "plastic_knife", "count": [ 0, 6 ] },
          { "item": "plastic_fork", "count": [ 0, 6 ] }
        ],
        "prob": 30
      },
      { "item": "plastic_spoon_kids", "prob": 35, "count": [ 1, 6 ] },
      [ "corkscrew", 75 ],

Everything inside the added collection has a chance of spawning together, so if you made that eg. a medium cardboard box and some packs of nails, it would spawn all those things together, implying a cardboard box full of packs of nails. It's not quite a container because our code isn't there yet, but it's a decent functional representation of one.

[arijust]

I will note that for my future PRs, but it would take me some time before I get used to it.

[I-am-Erk]

Yep no worries. I will probably make a second PR adjusting the changes in this one so you can see what I mean, and then if you want to further add cardboard boxes to spawn along with things that might spawn with boxes you'll be able to see how. TOGETHER, WE COULD FILL THE EARTH WITH CARDBOARD.

[arijust]

Alright, thanks.