Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

craftable stethoscope #35991

Merged

Conversation

misterprimus
Copy link
Contributor

Summary

SUMMARY: Content "craftable stethoscope"

Purpose of change

To fix some things in the game that don't make sense from a realism/balance perspective.

Describe the solution

  1. Allow crafting of stethoscopes. These are a pain to find, but you can't ever craft them, even though online tutorials show even a child can do it:
    https://www.thoughtco.com/make-your-own-stethoscope-2086570
    While not exactly something a doctor would ever show to a patient, it seems as though it should work for simple listening as in safe cracking.

Describe alternatives you've considered

Testing

Tested fix to see if behavior resulted in expected behavior and corrected unexpected behavior accordingly.

Additional context

N/A

Copy link
Contributor

@Davi-DeGanne Davi-DeGanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked article mentions a balloon -- indeed, a thin, flat, rubbery membrane is probably the most important part of this; it creates a large contact area with the object you're trying to listen to, and responds to and amplifies vibrations, all at once. I can't really think of a material that would substitute the balloon for this purpose, certainly nothing you've included in your recipe.

I would like to see a "balloon" clutter item added (perhaps to schools, child zombies, arcades, homes, and other places kids might be) and used in this recipe.

@Fris0uman
Copy link
Contributor

Fris0uman commented Dec 10, 2019

Adding balloons to the game would be nice, alternatively we have condoms already.

@curstwist curstwist added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Dec 10, 2019
@misterprimus
Copy link
Contributor Author

Adding balloons to the game would be nice, alternatively we have condoms already.

Yes I will take the condom approach.

@Rivet-the-Zombie
Copy link
Member

This makeshift recipe probably shouldn't be producing the same slick little stethoscope that you can find in doctor's offices, but rather a bigger, heavier makeshift version.

@misterprimus
Copy link
Contributor Author

misterprimus commented Dec 11, 2019

Done.

Copy link
Contributor

@Davi-DeGanne Davi-DeGanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Especially nice job covering all the bases with adding the new balloon item to item groups.

Just two things:

Copy link
Contributor

@Davi-DeGanne Davi-DeGanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for going the extra mile on this.

@mark7
Copy link
Contributor

mark7 commented Dec 12, 2019

I have to say that I'm not enthusiastic about this pull request from a gameplay standpoint.

This change will make it substantially-easier to get into safes. One will need fabrication(1), one of several common books, 1 hose from a smashed fridge, 2 commonly-dropped plastic bottles, a condom or balloon, and 30 duct tape/medical tape...and safes become openable. This avoids some of the reason for doing dangerous raids into doctor's offices in cities to get a stethoscope.

My thinking is that the gates that the map makers can place on accessing items are already pretty low. The general aim seems to be to try to extend the game before one gets to "uber-character", and gating access to safes seems to be an important part of this.

I don't know whether it's realistic or not to crack a safe with the items listed here. But I do wonder if it's a good idea to permit it from a gameplay standpoint.

If one makes a realism argument, then it might be fair to ask whether an average Joe who comes upon the above-mentioned items could reasonably crack a safe with them and the aid of a first-aid handbook.

I raised a similar issue with issue #31817, that makeshift lockpicks with their current recipe trivialized the bar to get through locked doors on "vaults" like gun stores. @kevingranade agreed, but there were objections from others that crafting a makeshift lockpick was not hard, but that being able to use one should be harder...and I think that they've a certain point.

Much as I dislike adding load to the patch creator, would it be reasonable, given that the bar is being lowered to create the tools to get into safes and that this is effectively lowering the bar to get into a safe, to also raise the bar to effectively use those tools? Bump up the skill requirements there?

What I'm getting at is that I'm not sure that having safes be hard to open is a bug, at least from a gameplay standpoint -- I'd call it a feature. It permits separating "later game" items from "immediately-available" items.

@Zireael07
Copy link
Contributor

Does the stethoscope item have any uses apart from cracking safes?

@misterprimus
Copy link
Contributor Author

I have to say that I'm not enthusiastic about this pull request from a gameplay standpoint.

This change will make it substantially-easier to get into safes. One will need fabrication(1), one of several common books, 1 hose from a smashed fridge, 2 commonly-dropped plastic bottles, a condom or balloon, and 30 duct tape/medical tape...and safes become openable. This avoids some of the reason for doing dangerous raids into doctor's offices in cities to get a stethoscope.

My thinking is that the gates that the map makers can place on accessing items are already pretty low. The general aim seems to be to try to extend the game before one gets to "uber-character", and gating access to safes seems to be an important part of this.

I don't know whether it's realistic or not to crack a safe with the items listed here. But I do wonder if it's a good idea to permit it from a gameplay standpoint.

If one makes a realism argument, then it might be fair to ask whether an average Joe who comes upon the above-mentioned items could reasonably crack a safe with them and the aid of a first-aid handbook.

I raised a similar issue with issue #31817, that makeshift lockpicks with their current recipe trivialized the bar to get through locked doors on "vaults" like gun stores. @kevingranade agreed, but there were objections from others that crafting a makeshift lockpick was not hard, but that being able to use one should be harder...and I think that they've a certain point.

Much as I dislike adding load to the patch creator, would it be reasonable, given that the bar is being lowered to create the tools to get into safes and that this is effectively lowering the bar to get into a safe, to also raise the bar to effectively use those tools? Bump up the skill requirements there?

What I'm getting at is that I'm not sure that having safes be hard to open is a bug, at least from a gameplay standpoint -- I'd call it a feature. It permits separating "later game" items from "immediately-available" items.

A few points here:

  1. Basic contact vibration rerouting devices like a basic stethoscope IS quite simple to make and these are sold quite inexpensively for car mechanics to search for air leaks (effectiveness is debatable where that is concerned).
  2. Safes in bank vaults appear to have been nerfed? I remember months ago a raid could easily result in multiple powered armor suits/helmets, whereas now the best I can hope for is some advanced books/manuals. Rest has been replaced with money and jewelry, which I suppose makes sense.
  3. You can't just get into a safe with a stethoscope as it is. You must still clear out the mobs (banks are often in city centers in big cities), beat the lethal secubots, crack the computer (needs very high computers skill) or smash the wall (requires jackhammer/pickaxe), etc... IRL a safe is there to slow down an intruder, not stop him. There's no solution in a typical commercial safe against an electric saw or similar item and unlike in the game this likely would not damage the contents.
  4. I would personally be able to craft a stethoscope fairly easily, but I'd have no clue how to crack a safe, especially a modern commercial one like that of a bank vault (is it really as simple as listening to the clicks it makes when you turn the dial?).

Perhaps the solution is to make safe-cracking something that can only be possible above a certain mechanics level or perhaps have a high chance of failure (with no penalty besides wasted time) at lower mechanics levels? But if this is done I think it should also be made possible (if time consuming) to SAFELY crack open a safe with a power drill or angle grinder.

@mark7
Copy link
Contributor

mark7 commented Dec 12, 2019

Does the stethoscope item have any uses apart from cracking safes?

Not in the base game -- there are no references to the item id "stethoscope", and the only relevant flag on the item is SAFECRACK, which is only used for safecracking. I suppose that someone may have a mod that I'm unaware of that does something else with it.

@mark7
Copy link
Contributor

mark7 commented Dec 12, 2019

Safes in bank vaults appear to have been nerfed? I remember months ago a raid could easily result in multiple powered armor suits/helmets, whereas now the best I can hope for is some advanced books/manuals

That looks like a34a096, yeah.

You must still clear out the mobs (banks are often in city centers in big cities), beat the lethal secubots, crack the computer (needs very high computers skill) or smash the wall (requires jackhammer/pickaxe), etc

I mean, sure, but if the safes aren't meant to be a substantial gate to the player, then what's the purpose of having them, in gameplay terms? I mean, I normally have the stuff the recipe requires even without shooting for it. I mean, as you point out, there's already a surrounding bank vault -- why not just have the stuff in the vault?

Like, there are a number of points where safes are used in the game, and I believe that they're generally-intended to gate "better" items from "not as good" items. I currently see f_safe_l referenced in bank.json, basement_meth.json, jewel_store.json, mall.json, mansion.json, office_cubical.json, pawn_shop.json, police_station.json, post_office.json, prison_1.json, river_shipwreck.json, s_hunting.json, veterinarian.json, house_w_palette.json, mall_palette.json, microlab.json, office.json, robocachq.json; Aftershock's map_palettes.json; Fuji_Structures' s_lightindustry_10.json; More_Locations' bandit tower and tpalettes; Salvaged_Robots' tpalettes.json.

Perhaps the solution is to make safe-cracking something that can only be possible above a certain mechanics level or perhaps have a high chance of failure (with no penalty besides wasted time) at lower mechanics levels?

Well, IME, time at a safe isn't too much of a constraint for me. Most places that have vaults are reasonably comfortable for the character to be spending time in, food isn't usually presently too-severe of a constraint.

(Also, in practice, I'd assume that it'd make sense from a quality-of-life standpoint to just subsume failures into it taking longer to crack a safe.)

But, again, that seems to lower the bar quite a bit.

I mean, I guess the real question is -- what's the main purpose of the PR? Is it primarily to address realism, or is it to alter gameplay, to lower the bar to get into safes?

If it's to address realism, for all I know, it's viable to make a stethoscope from these parts...but then, I have to say that I doubt that it'd be enough to get me in-real-life into a safe. And it seems like if the game goes in to address the former realism issue without also addressing the latter realism element, then it impacts gameplay.

From a realism standpoint, I imagine that I could probably eventually get into most safes (as you point out) with an angle grinder, agreed -- and maybe adding the ability to get into safes with an angle grinder is a fair change -- and from a gameplay standpoint, as long as they show up reasonably-infrequently, they don't kill the bar.

If it's to address gameplay, to lower the bar to get into safes -- you said that it was "a pain to find" stethoscopes, so I'm under the belief that that's at least a part goal -- then that's where I start to worry about the resulting bar being too low.

I mean, from a gameplay standpoint, I'd say that it's okay for, on a given run, some characters -- like the Burglar profession -- being able to get into safes early, and others not being able to do. Part of the appeal of roguelike games is in making each run different by throwing up a meaningfully-different set of constraints at the player each run. If I know that I have a pretty reliable way to get into safes early in each run, then "character can get into safes" stops being one of those inputs, and the gameplay becomes pretty formulaic in each game.

Right now, obtaining the ability to get into a safe means, for most characters, either being lucky, or having to scout around -- possibly even multiple towns -- until they can find a doctor's office, and then manage to get into it and search it. That's a significant project. It forces characters to move around and forces them to undertake sub-projects along the way. Sure, I mean, it takes time...but is "it's a substantial undertaking to get the ability to loot safes" a problem? I mean, it seems to me that the game generally benefits from having those large projects and requiring that travel and exploration and benefits from that degree of unpredictability.

@anothersimulacrum
Copy link
Member

anothersimulacrum commented Dec 13, 2019

The triviality of getting into safes (once you have the stethoscope) is the problem (and I'm not sure it's too much of a problem), not the ease of crafting the stethoscope.
It's also out of scope of this PR. I'd say make a separate issue or PR to resolve that.

@misterprimus
Copy link
Contributor Author

misterprimus commented Dec 13, 2019

Safes in bank vaults appear to have been nerfed? I remember months ago a raid could easily result in multiple powered armor suits/helmets, whereas now the best I can hope for is some advanced books/manuals

That looks like a34a096, yeah.

You must still clear out the mobs (banks are often in city centers in big cities), beat the lethal secubots, crack the computer (needs very high computers skill) or smash the wall (requires jackhammer/pickaxe), etc

I mean, sure, but if the safes aren't meant to be a substantial gate to the player, then what's the purpose of having them, in gameplay terms? I mean, I normally have the stuff the recipe requires even without shooting for it. I mean, as you point out, there's already a surrounding bank vault -- why not just have the stuff in the vault?

Like, there are a number of points where safes are used in the game, and I believe that they're generally-intended to gate "better" items from "not as good" items. I currently see f_safe_l referenced in bank.json, basement_meth.json, jewel_store.json, mall.json, mansion.json, office_cubical.json, pawn_shop.json, police_station.json, post_office.json, prison_1.json, river_shipwreck.json, s_hunting.json, veterinarian.json, house_w_palette.json, mall_palette.json, microlab.json, office.json, robocachq.json; Aftershock's map_palettes.json; Fuji_Structures' s_lightindustry_10.json; More_Locations' bandit tower and tpalettes; Salvaged_Robots' tpalettes.json.

Perhaps the solution is to make safe-cracking something that can only be possible above a certain mechanics level or perhaps have a high chance of failure (with no penalty besides wasted time) at lower mechanics levels?

Well, IME, time at a safe isn't too much of a constraint for me. Most places that have vaults are reasonably comfortable for the character to be spending time in, food isn't usually presently too-severe of a constraint.

(Also, in practice, I'd assume that it'd make sense from a quality-of-life standpoint to just subsume failures into it taking longer to crack a safe.)

But, again, that seems to lower the bar quite a bit.

I mean, I guess the real question is -- what's the main purpose of the PR? Is it primarily to address realism, or is it to alter gameplay, to lower the bar to get into safes?

If it's to address realism, for all I know, it's viable to make a stethoscope from these parts...but then, I have to say that I doubt that it'd be enough to get me in-real-life into a safe. And it seems like if the game goes in to address the former realism issue without also addressing the latter realism element, then it impacts gameplay.

From a realism standpoint, I imagine that I could probably eventually get into most safes (as you point out) with an angle grinder, agreed -- and maybe adding the ability to get into safes with an angle grinder is a fair change -- and from a gameplay standpoint, as long as they show up reasonably-infrequently, they don't kill the bar.

If it's to address gameplay, to lower the bar to get into safes -- you said that it was "a pain to find" stethoscopes, so I'm under the belief that that's at least a part goal -- then that's where I start to worry about the resulting bar being too low.

I mean, from a gameplay standpoint, I'd say that it's okay for, on a given run, some characters -- like the Burglar profession -- being able to get into safes early, and others not being able to do. Part of the appeal of roguelike games is in making each run different by throwing up a meaningfully-different set of constraints at the player each run. If I know that I have a pretty reliable way to get into safes early in each run, then "character can get into safes" stops being one of those inputs, and the gameplay becomes pretty formulaic in each game.

Right now, obtaining the ability to get into a safe means, for most characters, either being lucky, or having to scout around -- possibly even multiple towns -- until they can find a doctor's office, and then manage to get into it and search it. That's a significant project. It forces characters to move around and forces them to undertake sub-projects along the way. Sure, I mean, it takes time...but is "it's a substantial undertaking to get the ability to loot safes" a problem? I mean, it seems to me that the game generally benefits from having those large projects and requiring that travel and exploration and benefits from that degree of unpredictability.

I see the "safes" as internal safe deposit boxes, with the double metal doors acting as the real "vault door" that must be breached. This makes far more sense now that the vault loot is a lot more sensible. Frankly, the secubot loot might be the biggest prize to be had in some banks. I thnk there already is loot spawning on the bank floor near the safes.

As for what's in safes, that's anybody's guess. Right now the loot is hardly anything to write home about, as it should be since most folks' possessions are quite mundane - cheap jewelry and money. Maybe some gold. Nothing earthshattering in terms of gameplay.

As for why I wanted to do this PR, in addition to realism, the primary purpose is probably to get rid of the seemingly arbitrary and incredible luck-based approach to letting people get into safes. Basically, it just wasn't making sense to me that I needed to search for some seemingly magical stethoscope like it is The Chalice when:

  1. IRL I could make it myself, find it in ANY doctor's office, etc...
  2. A safe could easily be beaten by an angle grinder, an utterly mundane and extremely common (not UNcommon as you suggest) item, sold at Harbor Freight for $15!
  3. IRL the most difficult part of breaking into a safe: police (secubots, mobs) and the vault door itself, which is difficult to break into by simple virtue of how big and thick it is.

Basically it was absurd that I did all this hard work of slaughtering a small army and smashing through a thick carbon steel door only to be undone by a safe deposit box I could IRL break open with a claw hammer and a chisel.

Frankly, I don't see craftable stethoscopes as a negative gameplay balance issue anymore since the safe contents were rightly nerfed. At best it's a realism/"feel" issue of making safe cracking by stethoscope a mechanics skill and at the same time allowing one to do it with an angle grinder. Nothing so urgent that it needs to be lumped into this PR. Could be done in another one that also nerfs lockpicks.

@Rivet-the-Zombie Rivet-the-Zombie merged commit cf1dc76 into CleverRaven:master Dec 13, 2019
fengjixuchui added a commit to fengjixuchui/Cataclysm-DDA that referenced this pull request Dec 13, 2019
Merge pull request CleverRaven#35991 from misterprimus/craftable-stet…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants