-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize clothing stores #35940
Modernize clothing stores #35940
Conversation
dfe989e
to
3a59fac
Compare
May I ask if you can give us a demonstration of what they will look like now? Or what you have planned for the extra story/floor? |
cda938f
to
4ca4714
Compare
ebd4681
to
a7f1b1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor things. Excited to see this merge soon.
Co-Authored-By: I-am-Erk <[email protected]>
Co-Authored-By: I-am-Erk <[email protected]>
Co-Authored-By: I-am-Erk <[email protected]>
f850a0d
to
43966ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes for finesse but overall it could be merged as is.
{ "item": "mag_tailor", "count": [ 1, 10 ], "prob": 80 }, | ||
{ "item": "manual_tailor", "count": [ 1, 4 ], "prob": 80 }, | ||
{ "item": "tailor_portfolio", "prob": 20 }, | ||
{ "item": "tailor_japanese", "prob": 10 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should make it one or the other? Not required but it would help a bit with balance
{ "item": "tailor_japanese", "prob": 10 }, | |
{ | |
"distribution": [ | |
{ "item": "tailor_portfolio", "prob": 70 }, | |
{ "item": "tailor_japanese", "prob": 30 } | |
], "prob": 25 | |
}, |
This gives roughly the same chance of either appearing, but doesn't allow both to appear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's reasonable to allow both to appear. A well stocked tailors library is fairly likely to have stuff from around the world.
Summary
SUMMARY: Content "Overhaul clothing stores"
Purpose of change
Clothing stores feel like they're from 0.A. and they don't use modern mapgen.
Describe the solution
Update clothing stores to use palettes and SUS itemgroups. Add new multi z level clothing store maps.
Depends on #35932.
Testing
Game loads without errors and
s_clothes
is generated as expected.