Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize SUS itemgroups #35932

Merged
merged 2 commits into from
Dec 8, 2019
Merged

Reorganize SUS itemgroups #35932

merged 2 commits into from
Dec 8, 2019

Conversation

ymber
Copy link
Member

@ymber ymber commented Dec 7, 2019

Summary

SUMMARY: None

Purpose of change

Since we want to use SUS groups for much more stuff it will be a good idea to not leave them all in the same file.

Describe the solution

Reorganize SUS item groups by typical location.

Testing

Game loads correctly.

@ymber ymber mentioned this pull request Dec 7, 2019
Copy link
Member

@I-am-Erk I-am-Erk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest calling it household or domestic rather than house, since they're also for apartments and things. Otherwise good change that I was planning on doing myself soon. Thanks

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Dec 8, 2019
@ZhilkinSerg ZhilkinSerg merged commit 6b00ffc into CleverRaven:master Dec 8, 2019
@ymber ymber deleted the sus branch December 8, 2019 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants