Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish addition of new alcohols from #35614 #36084

Merged
merged 3 commits into from Dec 14, 2019
Merged

Finish addition of new alcohols from #35614 #36084

merged 3 commits into from Dec 14, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 13, 2019

Summary

SUMMARY: Content "Add new alcohols to recipes, and update descriptions"

Purpose of change

Fixes #35973.

Describe the solution

1- Fixed typo of Madeira.
2- Change name of Bristol sherry to Bristol Cream, as that's clearly what it refers to.
3- Removed mention of containers in the descriptions, changed to be more interesting(I hope 🤷‍♂).
4- Changed the new wines to inherit from sherry, and the whiskeys from whiskey.
5- Reduced sherry & variants' volume to 250ml, like the other strong alcohols.
5- Added new alcohols to strong mixed alcohol & Irish coffee options and cooking_components requirements.
6- Added cheap wine to cheap_wine requirement. Thonk

Describe alternatives you've considered

None.

Testing

Loaded game to see if load errors happened. Learned all recipes to see new options added.

Additional context

I don't drink, so don't ask me to gauge the fun values 😛.
Before
image
After
image

@kevingranade kevingranade merged commit 4e85a78 into CleverRaven:master Dec 14, 2019
@ghost ghost deleted the NewAlchoFix branch December 14, 2019 03:03
@Jovus
Copy link
Contributor

Jovus commented Dec 16, 2019

You may think you've escaped my influence with this PR, but I have IDEAS.

@ghost
Copy link
Author

ghost commented Dec 17, 2019

You may think you've escaped my influence with this PR, but I have IDEAS.

What did he mean by this? 🤔

@Jovus
Copy link
Contributor

Jovus commented Dec 17, 2019

A continuation of the repartee in #35973 dropped in here instead of there late at night by accident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap up loose ends for new alcohols from #35164
3 participants