Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap up loose ends for new alcohols from #35164 #35973

Closed
Davi-DeGanne opened this issue Dec 9, 2019 · 2 comments · Fixed by #36084
Closed

Wrap up loose ends for new alcohols from #35164 #35973

Davi-DeGanne opened this issue Dec 9, 2019 · 2 comments · Fixed by #36084

Comments

@Davi-DeGanne
Copy link
Contributor

Summary

To properly "finish" #35164, the following things should be done (see the PR for more details):

  • Add inheritance to the new alcohols as I pointed out in a review.
  • Capitalize proper nouns in the item names, and remove references to specific containers as pointed out by @Kodiologist.
  • Add the new alcohols to recipes, and cooking_components.json lists, as pointed out by @Jovus.
@Jovus
Copy link
Contributor

Jovus commented Dec 9, 2019

This looks like a good project for a new contributor who wants to get his feet wet with only very slightly more complicated JSONs, and who wants to figure out how to link PRs and Issues through Github. (That's me volunteering but noncommitally, and not before January due to travel.)

@ghost
Copy link

ghost commented Dec 13, 2019

This looks like a good project for a new contributor who wants to get his feet wet with only very slightly more complicated JSONs, and who wants to figure out how to link PRs and Issues through Github.

Nah, this is mine. 😈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants