Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonized field description affixes #35839

Merged

Conversation

ZhilkinSerg
Copy link
Contributor

Summary

SUMMARY: Infrastructure "Jsonized field description affixes'"

Purpose of change

Allow definition of description affixes for new field types via json.

Describe the solution

Load field type description affixes from field type json.

Testing

Make some selfies with pro-camera in-game standing in and near various fields and check field descriptions afterwards.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` Items / Item Actions / Item Qualities Items and how they work and interact Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Dec 3, 2019
@ZhilkinSerg ZhilkinSerg force-pushed the jsonize-field-description-affix branch 2 times, most recently from 8a4cd9b to 568e13b Compare December 3, 2019 22:12
src/field_type.h Outdated Show resolved Hide resolved
@ZhilkinSerg ZhilkinSerg force-pushed the jsonize-field-description-affix branch from 41961df to 305b103 Compare December 5, 2019 15:09
@kevingranade kevingranade merged commit 45a3b20 into CleverRaven:master Dec 9, 2019
@ZhilkinSerg ZhilkinSerg deleted the jsonize-field-description-affix branch December 9, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants