Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magiclysm - Golems #35658

Merged
merged 27 commits into from
Dec 31, 2019
Merged

Magiclysm - Golems #35658

merged 27 commits into from
Dec 31, 2019

Conversation

arijust
Copy link
Contributor

@arijust arijust commented Nov 22, 2019

Summary

SUMMARY: Mods "Add golems to Magiclysm"

Purpose of change

Introduces three golems:
Clay Golem, Stone Golem and Iron Golem.
While these can't be constructed by player, they still can be dismantled for resources they were made of.

Additional context

Temporary spawn point for these is forest.

I didn't have a better idea where to add them.
@arijust arijust changed the title [WIP] Magiclysm - Golems Magiclysm - Golems Nov 27, 2019
@arijust arijust marked this pull request as ready for review November 27, 2019 20:40
@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod Monsters Monsters both friendly and unfriendly. labels Nov 28, 2019
@KorGgenT KorGgenT self-assigned this Dec 10, 2019
Copy link
Member

@KorGgenT KorGgenT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs some minor work with the spells and some minor changes to the syntax of some of the json members. i have not yet tested them in game because of the spell issues.

data/mods/Magiclysm/Spells/monsterspells.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/Spells/monsterspells.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/Spells/monsterspells.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/items/constructs.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/items/constructs.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/items/constructs.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/monsters/monsters.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/monsters/monsters.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/monsters/monsters.json Outdated Show resolved Hide resolved
@@ -328,7 +328,101 @@
"harvest": "lemure",
"anger_triggers": [ "PLAYER_CLOSE" ],
"death_function": [ "NORMAL" ],
"regenerates": 1,
"flags": [ "SEES", "SMELLS", "HEARS", "STUMBLES", "PATH_AVOID_FIRE", "REVIVES" ]
"flags": [ "SEES", "SMELLS", "HEARS", "STUMBLES", "PATH_AVOID_FIRE", "REGENERATES_1", "REVIVES" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a rebase error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It happens.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally noticed that "regenerates" flag doesn't exist anymore.

@KorGgenT KorGgenT merged commit ab4acd2 into CleverRaven:master Dec 31, 2019
@arijust arijust deleted the magiclysm_golems branch December 31, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants