Camp upgrade vehicle fixes #36100
Merged
Camp upgrade vehicle fixes #36100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curstwist
added
<Bugfix>
Co-Authored-By: Kevin Granade <[email protected]>
Co-Authored-By: Kevin Granade <[email protected]>
Co-Authored-By: Kevin Granade <[email protected]>
fengjixuchui
added a commit
to fengjixuchui/Cataclysm-DDA
that referenced
this pull request
Dec 17, 2019
Merge pull request CleverRaven#36100 from davidpwbrown/camp_upgrade_v…
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Camp upgrade vehicle fixes"Purpose of change
Fixes #30691
Describe the solution
Add proper vehicle collision checks to update_mapgen for other jmapgen types.
Describe alternatives you've considered
In the linked issue, there is a comment stating that starting a faction camp on a vehicle makes the vehicle dissappear.
I noticed this too, it reappears after a while, but contsant unboarding vehicle debugmsgs appear, Ill try and fix this in a separate PR
Testing
Sent NPC at camp on mission to build tents, put vehicle over where the tents would appear, NPC could not be recalled ( with a popup info msg about there being a vehicle in the way )
Additional context
Thanks to ralreegorganon for assisting me through this, infact lets be honest, he wrote this commit mostly, told me to "clean it up" , seeing as I couldnt actually see anything wrong with it, I may not be the best person to judge what needs cleaning, but here it is.