locations_commercial.json added; item_groups clean up #35944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added locations_commercial.json file in itemgroups folder. Moved multiple lists in item_groups to either locations or locations_commercial
ZhilkinSerg
added
[JSON]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: Content "locations_commercial.json added; item_groups clean up"Summary
added locations_commercial.json file in itemgroups folder. Moved multiple lists in item_groups to either locations or locations_commercial
Purpose of change
item_groups decluttering and proper sorting of lists.
Describe the solution
As in summary: added new locations_commercial.json, moved 26 lists from item_groups.json to either locations or locations_commercial.jsons. I realize that is a lot to move in one PR, but I don't feel that these are controversial changes and the solution makes sense.
Describe alternatives you've considered
Testing
de-linted and spawned lists in game.
Additional context