Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonize hazardous waste sarcophagus #35998

Merged
merged 8 commits into from
Dec 25, 2019
Merged

Jsonize hazardous waste sarcophagus #35998

merged 8 commits into from
Dec 25, 2019

Conversation

Night-Pryanik
Copy link
Contributor

Summary

SUMMARY: Content "Jsonize hazardous waste sarcophagus."

Purpose of change

Jsonize hazardous waste sarcophagus.

Describe the solution

  • Draw json-variant based on hardcoded variant. Put some enhancements in layout and mapgen here and there (added air conditioners, servers, shredders, and other suitable terrains and furniture; tweaked monster, vehicle, and items spawn).
  • Removed draw_sarcophagus function from mapgen.cpp and map.h.
  • Put hardcoded variant overmap terrains into obsolete_terrains.json.
  • Made it possible to read fourth security reminder (Security Reminder [1058]) - it existed very long in game files, but due to technical limitations of our UI, it was impossible to place it in computer UI. Read it in underground level of HWS.
  • Put reminders to remove remains of hardcoded variant from everywhere they still exist after 0.E. or proper migration.

Describe alternatives you've considered

None.

Testing

Loaded game with old hardcoded variant already spawned in the world. Spawned new json-variant. No errors.

Additional context

None.

@Night-Pryanik Night-Pryanik added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display [C++] Changes (can be) made in C++. Previously named `Code` labels Dec 10, 2019
@Amoebka
Copy link
Contributor

Amoebka commented Dec 10, 2019

Have you fixed the elevator access yet? The code for it always spawns on the LOWER level, so the only way to break in is to dig.
It's also notable for being the only console in the game you can't hack. This should probably change?

@anothersimulacrum
Copy link
Member

You get the code from an NPC quest.

@ralreegorganon
Copy link
Contributor

You need to update the entries in the missions that reference this location since the overmap terrain ids are changing, and then test the missions after the change.

The location is assigned as a mission target here and the semantics of that will change because there were multiple locations with the old name but you'll have to pick one to target now.

The location is used as a destination here and that also changes the semantics because the location needs to be visited in order to complete the mission, and previously any of the basement locations would match it, but now you'll have to pick one of them.

@Night-Pryanik
Copy link
Contributor Author

@ralreegorganon done, thanks for reminding.

@Night-Pryanik
Copy link
Contributor Author

It's also notable for being the only console in the game you can't hack. This should probably change?

It's a quest/balance issue, I don't plan to change anything on this matter in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants