Changing plank weight and volume to 2200g and 4400mL

[Jovus]

Summary

SUMMARY: Balance "Update the volume and weight of planks to be more in line with real dimensional lumber"

Purpose of change

Planks as they currently exist are either too heavy or too small to represent real, common dimensional lumber, with a density of 0.93g/mL whereas common lumber sorts vary (roughly) between 0.4-0.7g/mL, according to http://woodmonsters.com/density-chart.html or https://cedarstripkayak.wordpress.com/lumber-selection/162-2/

(Disclaimer: I didn't actually know the densities involved before starting this, but I worked out a starting point from Home Depot's given lumber dimensions and weights found here: https://www.homedepot.com/p/2-in-x-4-in-x-96-in-Premium-Kiln-Dried-Whitewood-Stud-161640/202091220)

Describe the solution

I increased the volume of a plank from 1500mL to 4400mL and increased the weight of a plank from 1391g to 1400g. The latter is just for aesthetic purposes; I like round numbers and nine grams seems unlikely to go amiss, but it cuts down on the sig figs displayed, which I also like because we shouldn't be too precise about what exactly we're calling a plank.

Using the numbers from the Home Depot link above, if arranged like a 2x4 this new 'plank' is roughly 2"x4"x32", which fits the description decently and justifies it as a simple bashing weapon, whereas before it would have been right around a foot long, which is in no way a plank. Other dimensional arrangements are of course possible, but now the density and volume make sense of something you'd call a plank of construction wood instead a block of mahogany.

Describe alternatives you've considered

I considered changing the weight instead of the volume to rectify the density problem, or both the weight and volume to something closer to a real-life full 'plank' like you'd find at a hardware store, but chose against both options because this way we avoid introducing new mass conservation issues with recipe products.

Testing

As this is just changing some numbers in wood.json, I didn't do any testing.

[agm-114]

I've went over the math myself, and these number add up, the board in question would be about 3ft long which nicely matches the length of a long string, and as long string's have their length specified it might be worthwhile to mention it. Although if we're rounding having it be 4500ml and 1500g might be a bit neater

[I-am-Erk]

Although I like having the volume and size of a plank more precisely calculated, I don't recommend specifying what dimensions it is, as our recipes abstract planks to represent a wide variety of different dimensions of lumber. If we started specifying that they were 3' long we'd no longer be able to use them to frame walls, for example, and would need a new long plank item. That's getting a little more granular than we want.

[Davi-DeGanne]

Your math doesn't check out. Did you take into account that the actual dimensions of a 2x4 are 1.5" x 3.5"? Don't worry, I don't blame you if not, it's a pretty stupid convention, but most lumber widths and heights are about 0.5 inches smaller than stated; you can see this in the home depot page you linked, about halfway down it says

Common: 2 in. x 4 in. x 8 ft.; Actual: 1.5 in. x 3.5 in. x 96 in.

For example, a 2x4x32 is actually 1.5 * 3.5 * 32 = 168 in³ or about 2750 mL, not 4400 mL like you expressed above.

Additionally you contradict yourself: You say wood density is 0.4-0.7g/mL, but your proposed change is 1400 g / 4400mL ~= 0.32 g/mL.

[I-am-Erk]

The dimensions themselves are really irrelevant as stated above, but that density does not indeed check out. I'd set it to about 0.5 g/mL and keep the volume at 4400, so put it to about 2200g. A 3' long piece of 2x4 is pretty tiny, with the error DaviBones noticed that puts it at least to around 50" long by my reckoning (1.5"x3.5"x50" = 0.157 cubit ft = 4.445 liters), which is really a more reasonable length anyway

[Jovus]

My one concern with increasing the weight to 2200g is that gross changes in the weight might cause weird issues with recipes further down the line. However, you all know more about the recipes than I do, and increasing the weight is better than decreasing it - weight can always be lost through manufacturing.

This leaves me with a question about this repo, though. Would it be better, for such a tiny change, to squash commit, or keep the history intact?

[Jovus]

I've just changed plank weight to 2200g and volume to 4400mL and tried to squash commits to help keep the history clean for this PR. I also changed the name of the PR to be accurate, since I'd previously confused the weight and volume in the title of the PR (1400mL and 4400g instead of now 2200g and 4400mL). This makes plank density neatly 0.5g/mL which I agree is a good number.

Just FYI but I'm leaving for Switzerland tomorrow so if this doesn't get merged soon and needs my input I might be a bit more lengthy in response time, but I should still be able to shepherd this there. (I hope. Unless google throws a fit because I'll be logging in from a new computer.)

[Davi-DeGanne]

gross changes in the weight might cause weird issues with recipes further down the line

This is a good observation, and it's good to be thinking about these things. I did a workspace search for "2x4" and while there were way too many entries to look through them exhaustively, most usage of planks for non-construction crafting don't leave the plank intact -- e.g. wooden arrows/bolts, tool handles (whittled to a rod-shape), bows, etc. Those can be thought of as using a set amount of wood, thus don't care about the weight of the input plank.

The only exceptions that jump out at me are perhaps the two wooden "armor" pieces: 2byarm_guard and 2byshin_guard. You could certainly do a reality check on those as part of this PR, or even a separate PR, if you'd like, but I wouldn't say it's necessary or very important.

[I-am-Erk]

The 2-by guards probably just need saws in their crafting requirements and splinters in their byproducts

[Jovus]

I think that's a great idea for a follow-up PR, and I'll probably get on that after Christmas if I don't get swamped by work.