Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "looks_like" to all furniture and terrain #35371

Closed
wants to merge 5 commits into from
Closed

Add "looks_like" to all furniture and terrain #35371

wants to merge 5 commits into from

Conversation

XygenSS
Copy link
Contributor

@XygenSS XygenSS commented Nov 7, 2019

Adds "looks_like" line to all terrain and furniture to help out tileset devs.

Summary

SUMMARY: Infrastructure Adds looks_like to all terrain and furniture entries

Purpose of change

Contributes to #34230.

Describe the solution

looks_like value have been added to all terrain and furniture JSON entries. One file named "looks_like hierarchy" have been added to /doc, it can be deleted when 34230 is fully resolved. Currently, all tiles eventually regress into t_rock and t_rock_floor which looks_like eachother. This can be easily changed if whitelist of some sort is added by editing a few major tiles (like t_floor and t_wall).

Describe alternatives you've considered

Not having stupid entries (e.g. an egg sack looks like a pile of rubble, which looks like rock floor) could've made more sense, but having everything consolidate into a few important tiles probably makes fixing stuff a bit easier (I think).

Testing

Not sure how to do it myself, but making a tileset with only t_rock and t_rock_floor to see if everything works perfectly could make sense.

Additional context

none

Adds "looks_like" line to all terrain and furniture to help out tileset devs.
@ghost
Copy link

ghost commented Nov 7, 2019

looks_like Teamup time? 🎉

@XygenSS
Copy link
Contributor Author

XygenSS commented Nov 7, 2019

Teamup time? 🎉

I guess?

@curstwist curstwist added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. and removed Items / Item Actions / Item Qualities Items and how they work and interact labels Nov 7, 2019
Copy link
Member

@I-am-Erk I-am-Erk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got about halfway through. I will try to do more later. For the remaining half though, please try not to change an existing looks_like unless you've got a solid rationale, there are a lot here where you're removing what was a pretty good tag in favour of something that doesn't get the point across as effectively.

data/json/furniture_and_terrain/furniture-appliances.json Outdated Show resolved Hide resolved
data/json/furniture_and_terrain/furniture-decorative.json Outdated Show resolved Hide resolved
data/json/furniture_and_terrain/furniture-decorative.json Outdated Show resolved Hide resolved
data/json/furniture_and_terrain/furniture-eggs.json Outdated Show resolved Hide resolved
data/json/furniture_and_terrain/furniture-medical.json Outdated Show resolved Hide resolved
data/json/furniture_and_terrain/furniture-migo.json Outdated Show resolved Hide resolved
data/json/furniture_and_terrain/furniture-migo.json Outdated Show resolved Hide resolved
data/json/furniture_and_terrain/furniture-plumbing.json Outdated Show resolved Hide resolved
data/json/furniture_and_terrain/furniture-plumbing.json Outdated Show resolved Hide resolved
@XygenSS
Copy link
Contributor Author

XygenSS commented Nov 8, 2019

got it, gonna fix that, do other half, tyvm

@XygenSS XygenSS changed the title Add "looks_like" to all entries Part #1 Add "looks_like" to all furniture and terrain Nov 11, 2019
Fixed nonsense looks_like entries based on feedback.
@XygenSS
Copy link
Contributor Author

XygenSS commented Nov 11, 2019

uhhhhhhhhhhhhh I updated the branch from master... Not sure if I messed up anything but am I not supposed to do that? How do I delete a commit?

@stale
Copy link

stale bot commented Dec 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Dec 11, 2019
@I-am-Erk
Copy link
Member

I-am-Erk commented Jan 5, 2020

Is this something you're interested in finishing or not? You can get help fixing your data tree over on discord if you're confused about it

@stale stale bot removed the stale Closed for lack of activity, but still valid. label Jan 5, 2020
@ZhilkinSerg ZhilkinSerg changed the base branch from master to dev March 18, 2020 07:02
@ZhilkinSerg ZhilkinSerg force-pushed the dev branch 3 times, most recently from ad63e77 to 8e68539 Compare April 1, 2020 12:18
@kevingranade kevingranade force-pushed the dev branch 2 times, most recently from b6b2e5b to 0b32f62 Compare April 2, 2020 06:30
@kevingranade kevingranade force-pushed the dev branch 2 times, most recently from 621a68e to b7106d0 Compare April 2, 2020 07:42
@ZhilkinSerg ZhilkinSerg force-pushed the dev branch 3 times, most recently from 0f30a43 to d432807 Compare April 2, 2020 12:55
@ZhilkinSerg ZhilkinSerg changed the base branch from dev to master April 7, 2020 23:38
@ZhilkinSerg ZhilkinSerg added the stale Closed for lack of activity, but still valid. label Apr 30, 2020
@ZhilkinSerg
Copy link
Contributor

Feel free to reopen if you want working on it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON stale Closed for lack of activity, but still valid.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants