-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "looks_like" to all furniture and terrain #35371
Conversation
Adds "looks_like" line to all terrain and furniture to help out tileset devs.
looks_like Teamup time? 🎉 |
I guess? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got about halfway through. I will try to do more later. For the remaining half though, please try not to change an existing looks_like unless you've got a solid rationale, there are a lot here where you're removing what was a pretty good tag in favour of something that doesn't get the point across as effectively.
got it, gonna fix that, do other half, tyvm |
Fixed nonsense looks_like entries based on feedback.
uhhhhhhhhhhhhh I updated the branch from master... Not sure if I messed up anything but am I not supposed to do that? How do I delete a commit? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
Is this something you're interested in finishing or not? You can get help fixing your data tree over on discord if you're confused about it |
ad63e77
to
8e68539
Compare
b6b2e5b
to
0b32f62
Compare
621a68e
to
b7106d0
Compare
0f30a43
to
d432807
Compare
Feel free to reopen if you want working on it again. |
Adds "looks_like" line to all terrain and furniture to help out tileset devs.
Summary
SUMMARY: Infrastructure Adds looks_like to all terrain and furniture entries
Purpose of change
Contributes to #34230.
Describe the solution
looks_like value have been added to all terrain and furniture JSON entries. One file named "looks_like hierarchy" have been added to /doc, it can be deleted when 34230 is fully resolved. Currently, all tiles eventually regress into t_rock and t_rock_floor which looks_like eachother. This can be easily changed if whitelist of some sort is added by editing a few major tiles (like t_floor and t_wall).
Describe alternatives you've considered
Not having stupid entries (e.g. an egg sack looks like a pile of rubble, which looks like rock floor) could've made more sense, but having everything consolidate into a few important tiles probably makes fixing stuff a bit easier (I think).
Testing
Not sure how to do it myself, but making a tileset with only t_rock and t_rock_floor to see if everything works perfectly could make sense.
Additional context
none