Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor typo fixes and new content to hints #36019

Merged
merged 4 commits into from
Dec 12, 2019

Conversation

Jerimee
Copy link
Contributor

@Jerimee Jerimee commented Dec 11, 2019

Summary

SUMMARY: None

Describe the solution

Copy edits and creation of a handful of new tips.

Describe alternatives you've considered

Submitting copy edits separately from original content.

Copy link
Member

@anothersimulacrum anothersimulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to lint.

@Jerimee
Copy link
Contributor Author

Jerimee commented Dec 11, 2019

hmm... I actually did, or I thought I did. I'm sorry. Let me figure out what I smurfed up

@Jerimee
Copy link
Contributor Author

Jerimee commented Dec 11, 2019

I think the issue is that I cut and paste from windows into browser, and that is messing up the unicode-bom-special-character-witchery for the … character... (… is a single char, whereas this - ... - is three characters)

@anothersimulacrum
Copy link
Member

The thing I noticed is that you have tabs instead of spaces.

@Jerimee
Copy link
Contributor Author

Jerimee commented Dec 11, 2019

On the off chance that this latest version passes all checks, please note that I've replaced all instances of U+2026 : HORIZONTAL ELLIPSIS {three dot leader} with a simpler ... (three periods U+002E).

If this is undesirable, please do not merge.

@kevingranade
Copy link
Member

Nope we want U+2026 : HORIZONTAL ELLIPSIS everywhere.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants