(done) Removes long grass from regional terrain lists, makes it into a map extra #35990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I-am-Erk
added
<Bugfix>
linting and fix leftover from testing fix cp error switch to update mapgen mode begin integrating update_mapgen Update wilderness.json Update wilderness.json add shed Update regional_map_settings.json adjust frequencies based on playtest lint Update wilderness.json
I-am-Erk
force-pushed
the
field-extras
branch
from
4fad4d8 to
a8bec97
Compare
I-am-Erk
changed the title
|
My bad, this is failing a consistency check |
Co-Authored-By: Kevin Granade <[email protected]>
|
The frequencies need to be shuffled around a bit more I think, but I also think the fact that it addresses the stated problem with long grass is more important than the sometimes odd field contents that result. |
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/random-encounter-json-location/22104/5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Removes long grass from random spawns in fields, adds new field map extras"Purpose of change
Grass generally grows at a uniform length on a meter-per-meter basis. Patches of knee length grass amidst a field should be either large, or nonexistent.
Describe the solution
This removes random spatterings of long grass from fields and anywhere else using regional groundcover, and adds a new map extra that is a patch of long grass and flowers.
In the process I have also added a copse of trees, a fallen-down shed with no roof, made mx_pond spawn in fields as well, and significantly increased the number of map extras spawning in fields, with a corresponding frequency drop for the other extras so that the mundane stuff shows up often and keeps them varied.
According to Kevin, this is at least a partially satisfactory solution to #28215. I don't really agree, I think the repeated message issue is deeper than that, but it gets it out of the way enough to get it off the 0.E blockers list at least. (Edit: i forgot an earlier fix had already improved the problem, so I guess this is icing on the cake and finishes the last outstanding suggestion there)
Describe alternatives you've considered
Testing
Below: the long grass is now gone. Smooth fields.
Below: a patch of long grass in a field
Another type of long grass patch, this one done through randomly overlaying smaller nests to create a rougher shape:
Below: A copse of trees
Below: A pond in a field (map extra by ralreegorganon, I just added it)
Below: Random spawned derelict sheds in a field
Additional context