change parameter of plthrow from int to item_location #36106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
[C++]
BevapDin
reviewed
Dec 14, 2019
|
currently having an issue with a seg fault while targeting. will revisit a little later. |
|
and now that i load it again, 12 hours later, i can't replicate the crash. i changed item_location to a copy instead of a reference. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "refactor plthrow"Purpose of change
changes the parameter of avatar_action::plthrow from an
int posto anitem_locationDescribe alternatives you've considered
Testing
load up a game, and throw all of the items in my inventory, either using the
tmenu or selecting the item specifically.Additional context
requires #36016 as this pr is based on those commits