Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and migrate most Realguns content to core #35805

Merged
merged 3 commits into from
Dec 9, 2019

Conversation

Rail-Runner
Copy link
Contributor

@Rail-Runner Rail-Runner commented Dec 1, 2019

Summary

SUMMARY: Content "Update and migrate most Realguns content to core"

Purpose of change

Prevent mod content from becoming broken as updates to core game happen (as long as said content is actually reasonable to have in core)

Describe the solution

Move JSON entries from "realguns" folder to appropriate core folders, as well as update them to be more consistent and actually working with current game version.

Had to do some changes to core content as well:

  1. Reduced M1911A1 in .38 Super magazine capacity to 9 from 10, seems like it really is 9 rather than 10.
  2. Taurus Raging Bull no longer can fire .410 shot ammo; newly added Taurus Raging Judge Magnum does that now.
  3. Added .38 6-round speedloader, to go with S&W Model 10 revolver.
  4. .454 speedloader can hold .410 shot ammo as well now.

Describe alternatives you've considered

None.

Testing

Copied changes over to game files, made sure that it runs fine, messed around with a couple added guns to make sure that they behave as expected.

Additional context

Any reference for how common the added firearms would be could be useful; I didn't change them from what the mod had.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics labels Dec 2, 2019
data/json/itemgroups/guns.json Outdated Show resolved Hide resolved
data/json/itemgroups/guns.json Outdated Show resolved Hide resolved
data/json/itemgroups/magazines.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Ranged Ranged (firearms, bows, crossbows, throwing), balance, tactics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants