Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate integer sound priorities to existing enumerated sound categories #35970

Merged
merged 2 commits into from
Dec 11, 2019

Conversation

Davi-DeGanne
Copy link
Contributor

@Davi-DeGanne Davi-DeGanne commented Dec 9, 2019

Summary

SUMMARY: None

Purpose of change

There were lot of weird and unnecessary static casts between integers and sound_t enumerations. It was bad for readability, and I suspect the unintuitive conversions are what lead to another oversight where the default category for a lot of NPC speech was sound_t::background rather than sound_t::speech.

Describe the solution

Finish migration of sound priorities to new sound category enumeration.

Describe alternatives you've considered

Testing

@davidpwbrown mentioned that it might be worth testing NPC investigation behavior:

Id suggest, teleporting to refugee center, with NPCs on, then bash a wall to make an alert noise, the guards there will go "whats that?" and move to investigate
the thing to watch out for is if the other guards then investigate the guard who said "whats that?"
and create an investigation chain reaction

Thankfully for my testing dummy's eardrums and sanity, no "investigation chain reaction" occured 😁

Additional context

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Sound Events Sound events handling in the game labels Dec 9, 2019
It's short enough to fit into 100 characters now.

Co-Authored-By: ZhilkinSerg <[email protected]>
@ZhilkinSerg ZhilkinSerg merged commit 7151997 into CleverRaven:master Dec 11, 2019
@Davi-DeGanne Davi-DeGanne deleted the enum-sound-priority branch December 14, 2019 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Sound Events Sound events handling in the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants