Migrate integer sound priorities to existing enumerated sound categories #35970
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
There were lot of weird and unnecessary static casts between integers and sound_t enumerations. It was bad for readability, and I suspect the unintuitive conversions are what lead to another oversight where the default category for a lot of NPC speech was
sound_t::background
rather thansound_t::speech
.Describe the solution
Finish migration of sound priorities to new sound category enumeration.
Describe alternatives you've considered
Testing
@davidpwbrown mentioned that it might be worth testing NPC investigation behavior:
Thankfully for my testing dummy's eardrums and sanity, no "investigation chain reaction" occured 😁
Additional context