Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further expand regional terrains and work them into some map palettes #35836

Merged
merged 14 commits into from
Dec 8, 2019

Conversation

I-am-Erk
Copy link
Member

@I-am-Erk I-am-Erk commented Dec 3, 2019

Summary

SUMMARY: Infrastructure "Further expands regional pseudoterrains and works them into some map palettes"

Purpose of change

Regional terrains were added in #35627 and expanded in #35669. This powerful new feature needs some further expansion to be fully useful, eg. in the addition of new biome types, or for the rapid adjustment of the appearance of terrain types over all maps.

Describe the solution

Added t_region_groundcover_forest and _swamp
Added f_region_water_plant
Debated adding t_region_tree_swamp. Might still do it but I'm trying to think of a more elegant solution than that.

Converted occurrence of trees and grass and shrubs and flowers to regional equivalents in several map palettes, and will continue to do so. This adds some variance to maps, and standardizes the occurrence of long grass and stuff like that. Later, it will mean that a biome can specify different appearances, such as sand and dry earth.

Describe alternatives you've considered

There are infinite ways the terrains could be broken down.

There's some argument for keeping more specific appearances of things like t_tree, where one might want specifically an oak tree, but I don't think there are many of those and overall it would be better to ask for a shade tree and allow some random variation I think.

Testing

When it's done.

@I-am-Erk I-am-Erk added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. labels Dec 3, 2019
@I-am-Erk I-am-Erk marked this pull request as ready for review December 6, 2019 19:58
@ZhilkinSerg ZhilkinSerg merged commit 6cdfcc5 into CleverRaven:master Dec 8, 2019
@I-am-Erk I-am-Erk deleted the regional-terrain2 branch April 20, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants