Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor copy edits #36023

Closed
wants to merge 1 commit into from
Closed

minor copy edits #36023

wants to merge 1 commit into from

Conversation

Jerimee
Copy link
Contributor

@Jerimee Jerimee commented Dec 11, 2019

Summary

SUMMARY: None

Describe the solution

Copy edits and creation of a handful of new tips. Weight most common swears in swear snippet.

Describe alternatives you've considered

Submitting copy edits separately from original content.

@ZhilkinSerg
Copy link
Contributor

ZhilkinSerg commented Dec 11, 2019

Am I understanding correctly you are duplicating entries to increase their weight? I think we better expand the snippet code to allow proper weighted lists there.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Dec 11, 2019
@Jerimee
Copy link
Contributor Author

Jerimee commented Dec 11, 2019

Sounds good - should I submit a feature request? (I'm too new to the project and too lousy a programmer to attempt it myself.)

@Jerimee
Copy link
Contributor Author

Jerimee commented Dec 11, 2019

close PR

@Jerimee Jerimee closed this Dec 11, 2019
@Jerimee Jerimee deleted the patch-4 branch December 11, 2019 22:12
@ZhilkinSerg
Copy link
Contributor

Sounds good - should I submit a feature request? (I'm too new to the project and too lousy a programmer to attempt it myself.)

You can try adding necessary code yourself or make a feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants