Implement iterators for JsonArray: #35852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to iterate over a `JsonArray` with a range-based for loop. Changes some code to use the form of iterating. This now also works with unnamed `JsonArray` instances, e.g. `for( ... : foo.get_array( ... ) )`.
ZhilkinSerg
added
[C++]
Functions take a copy of the JSON object, so the members in the original object are never visited and that is reported as error.
|
Looks good for me, but clang and gcc 5.3 are going crazy. |
Yes, I'm looking at you GCC 5.3.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: Infrastructure "Implement iterators for JsonArray"This allows to iterate over a
JsonArraywith a range-based for loop.Changes some code to use the form of iterating. This now also works with unnamed
JsonArrayinstances, e.g.for( ... : foo.get_array( ... ) ).