Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make batteries more standardized #35827

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

AlexMooney
Copy link
Contributor

@AlexMooney AlexMooney commented Dec 3, 2019

Summary

SUMMARY: Bugfixes "Corrects some nonstandard battery slots"

Purpose of change

Noticed that I couldn't reload a cellphone with a disposable light battery.

Describe the solution

Review all battery magazines across the json files to correct discrepancies.

Describe alternatives you've considered

The foodperson_mask was the only example I saw of a light and medium battery compatible item. I consider this to be a mistake, but the choice between medium and light is fairly arbitrary. Since the mask is a gigantic 16 liters, I decided to go with medium.

Testing

Ran json linting. Reloaded my cellphone with a light disposable battery.

Additional context

The battery lists are not always in the same order from item to item. I think the proper way to fix that is to overhaul the batteries system to have size flag(s) for items and then adding a new Light battery will propagate naturally. We could spend the effort to put them in a consistent order now, but I don't think it's worth the time.

Will removing some batteries from the foodperson_mask break save games? I didn't test.

@anothersimulacrum
Copy link
Member

I consider this to be a mistake

The foodperson mask is fairly vital to true foodpeople, so I think this is purposeful, because light batteries are generally easier to acquire than medium batteries, making it easier on beginning true foodpeople. You may want to ask the creator, but if you're going to go for one or the other, I'd suggest light over medium.

@AlexMooney
Copy link
Contributor Author

@Fris0uman can you take a look? I rebalanced the Foodperson© mask to last 8 hours, 20 minutes with a medium battery. It doesn't take light batteries now. Would you prefer something else?

8 hours * 60 min / hour = 480 minutes, so a Foodperson works for 8 hours
and 20 minutes with a medium battery and 1 second turns.
@Fris0uman
Copy link
Contributor

The bigger the battery the longer anyone trying it ON will get trapped, but on the other hand 8h is the duration of a long day shift so that's coherent with the lore of the mask. If you really think it's not acceptable to accept both light and medium battery keep the medium one, otherwise leave it as it was.

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Battery / UPS Electric power management Items / Item Actions / Item Qualities Items and how they work and interact labels Dec 3, 2019
@ZhilkinSerg ZhilkinSerg merged commit 466061a into CleverRaven:master Dec 3, 2019
@AlexMooney AlexMooney deleted the standard_batteries branch December 3, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Battery / UPS Electric power management Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants