Make batteries more standardized #35827
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Corrects some nonstandard battery slots"
Purpose of change
Noticed that I couldn't reload a cellphone with a disposable light battery.
Describe the solution
Review all battery magazines across the json files to correct discrepancies.
Describe alternatives you've considered
The
foodperson_mask
was the only example I saw of a light and medium battery compatible item. I consider this to be a mistake, but the choice between medium and light is fairly arbitrary. Since the mask is a gigantic 16 liters, I decided to go with medium.Testing
Ran json linting. Reloaded my cellphone with a light disposable battery.
Additional context
The battery lists are not always in the same order from item to item. I think the proper way to fix that is to overhaul the batteries system to have size flag(s) for items and then adding a new Light battery will propagate naturally. We could spend the effort to put them in a consistent order now, but I don't think it's worth the time.
Will removing some batteries from the
foodperson_mask
break save games? I didn't test.