Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonize skill companion rank factors #35842

Conversation

ZhilkinSerg
Copy link
Contributor

Summary

SUMMARY: Infrastructure "Jsonize skill companion rank factors"

Purpose of change

Allow defining of companion rank combat/survival/industry factors in json for vanilla and mods skills.

Describe the solution

  {
    "type": "skill",
    "ident": "unarmed",
    "name": "unarmed combat",
...
    "companion_combat_rank_factor": 1,
    "companion_survival_rank_factor": 1,
...
  },

@ZhilkinSerg ZhilkinSerg added NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON Missions Quests and missions [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Dec 3, 2019
@ZhilkinSerg ZhilkinSerg force-pushed the jsonize-skill-companion-rank-factors branch from 3be6e22 to d635d12 Compare December 3, 2019 22:44
@Rivet-the-Zombie Rivet-the-Zombie merged commit a6a0423 into CleverRaven:master Dec 6, 2019
@ZhilkinSerg ZhilkinSerg deleted the jsonize-skill-companion-rank-factors branch December 6, 2019 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style [JSON] Changes (can be) made in JSON Missions Quests and missions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants