More name, weight, and volume updates #35903
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Purpose of change
The purpose of this change is to increase consistency of our Json, and to perhaps deprecate the old style at some point later on.
For names, we use the translation object, which is like so:
{ "str": string, "str_pl": string }
for volumes, we want to use units strings, and try to keep to larger units when possible:
"750 ml"
or"1 L"
similar for weights:
"899 g"
or"4 kg"
or"28 mg"
Describe the solution
go through the json definitions in the following files:
Testing
Loaded the game, observe no errors. then view a couple of entries from each file to see that the name displays properly. Spawn in a few of these and kill them, observing that their corpses did not change in volume or weight.