Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Lizardfolk #35138

Merged
merged 17 commits into from
Dec 7, 2019
Merged

Conversation

kmullinax
Copy link
Contributor

@kmullinax kmullinax commented Oct 29, 2019

Summary

SUMMARY: Mods "Magiclysm Lizardfolk Addition"

Purpose of change

Adds Lizardfolk species to Magiclysm, including related weapons, spells, etc.

Testing

Some testing of individual and group attacks with Lizardfolk. Missing spawning abilities with monstergroups at this time.

@kevingranade kevingranade requested a review from KorGgenT October 29, 2019 18:04
@curstwist curstwist added [JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod Monsters Monsters both friendly and unfriendly. labels Oct 29, 2019
@KorGgenT KorGgenT self-assigned this Oct 29, 2019
@KorGgenT KorGgenT changed the title Kmullinax magiclysm Lizardfolk Oct 29, 2019
@KorGgenT KorGgenT changed the title Lizardfolk [Magiclysm] Lizardfolk Oct 29, 2019
@KorGgenT
Copy link
Member

looks like you deleted some stuff related to stirge, lemure, etc.
Can you please restore that?
Additionally, it appears you need to lint your json

@kmullinax
Copy link
Contributor Author

kmullinax commented Oct 30, 2019 via email

@kmullinax
Copy link
Contributor Author

kmullinax commented Oct 30, 2019 via email

@KorGgenT
Copy link
Member

all right, i fixed the removed stuff from the harvest file. now all you need to do is lint your json.

@kmullinax
Copy link
Contributor Author

kmullinax commented Nov 1, 2019 via email

data/mods/Magiclysm/Spells/lizardfolk_shaman.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/items/weapons.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/monster_attacks.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/monsters/lizardfolk.json Outdated Show resolved Hide resolved
Copy link
Member

@KorGgenT KorGgenT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK so i have changed the PR to be sufficiently ready for merge, if someone else can merge it so there's an extra pair of eyes on it, since I made significant changes.

@KorGgenT KorGgenT removed their assignment Dec 6, 2019
@KorGgenT KorGgenT merged commit c95dfba into CleverRaven:master Dec 7, 2019
@AMurkin
Copy link
Contributor

AMurkin commented Dec 8, 2019

Travis didn't run tests: Early exit on just-json change
But newer PRs have Failed to visit member errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants