-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Magiclysm] Lizardfolk #35138
[Magiclysm] Lizardfolk #35138
Conversation
looks like you deleted some stuff related to stirge, lemure, etc. |
Hi -
Okay so this is all new to me. I didn't delete anything... I think the
issue is I downloaded Magiclysm early last week to work on it and only
understood how to use Github today.
So I created a fork with my new account (created today) and uploaded my new
and changed files. If one of those files was changed on Github while I was
tinkering with it, I wouldn't have had the newest version.
KorGenT set me up on Github today so that shouldn't happen again, but I
don't know what you're talking about as far as stirge, lemure, etc... i
haven't come across any of that and I've looked through every Magiclysm
file.
…On Tue, Oct 29, 2019 at 3:32 PM Curtis Merrill ***@***.***> wrote:
looks like you deleted some stuff related to stirge, lemure, etc.
Can you please restore that?
Additionally, it appears you need to lint your json
<http://dev.narc.ro/cataclysm/format.html>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#35138?email_source=notifications&email_token=ANT5346E6HTI62YAEIB7MUTQRCFWTA5CNFSM4JGKPCN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECRZUIY#issuecomment-547592739>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANT5347XKMPB352QCH263CDQRCFWTANCNFSM4JGKPCNQ>
.
|
If you can return the repository to the state it was in prior to my pull
request, I can modify the new forked files instead of the ones from early
last week and re-upload everything.
Also...that's a cool tool, that LINT thing wow.
On Tue, Oct 29, 2019 at 8:05 PM Kevin Mullinax <[email protected]>
wrote:
… Hi -
Okay so this is all new to me. I didn't delete anything... I think the
issue is I downloaded Magiclysm early last week to work on it and only
understood how to use Github today.
So I created a fork with my new account (created today) and uploaded my
new and changed files. If one of those files was changed on Github while I
was tinkering with it, I wouldn't have had the newest version.
KorGenT set me up on Github today so that shouldn't happen again, but I
don't know what you're talking about as far as stirge, lemure, etc... i
haven't come across any of that and I've looked through every Magiclysm
file.
On Tue, Oct 29, 2019 at 3:32 PM Curtis Merrill ***@***.***>
wrote:
> looks like you deleted some stuff related to stirge, lemure, etc.
> Can you please restore that?
> Additionally, it appears you need to lint your json
> <http://dev.narc.ro/cataclysm/format.html>
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#35138?email_source=notifications&email_token=ANT5346E6HTI62YAEIB7MUTQRCFWTA5CNFSM4JGKPCN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECRZUIY#issuecomment-547592739>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ANT5347XKMPB352QCH263CDQRCFWTANCNFSM4JGKPCNQ>
> .
>
|
all right, i fixed the removed stuff from the harvest file. now all you need to do is lint your json. |
Okay great - will do.
…On Thu, Oct 31, 2019 at 12:11 PM Curtis Merrill ***@***.***> wrote:
all right, i fixed the removed stuff from the harvest file. now all you
need to do is lint your json.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#35138?email_source=notifications&email_token=ANT5345HEJ5YK3KDGP6BVDDQRL7R3A5CNFSM4JGKPCN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECYLCXI#issuecomment-548450653>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANT5344G7GDZX7YCG5HUQN3QRL7R3ANCNFSM4JGKPCNQ>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK so i have changed the PR to be sufficiently ready for merge, if someone else can merge it so there's an extra pair of eyes on it, since I made significant changes.
Summary
SUMMARY: Mods "Magiclysm Lizardfolk Addition"
Purpose of change
Adds Lizardfolk species to Magiclysm, including related weapons, spells, etc.
Testing
Some testing of individual and group attacks with Lizardfolk. Missing spawning abilities with monstergroups at this time.