Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rope and cordage overhaul #35700

Merged
merged 2 commits into from
Dec 4, 2019
Merged

Conversation

Rail-Runner
Copy link
Contributor

@Rail-Runner Rail-Runner commented Nov 24, 2019

Summary

SUMMARY: Content "Overhaul rope and cordage uses in recipes"

Purpose of change

Improve the consistency of recipes which use tying material, both current and future ones, while allowing to easily add new kinds of tying material as well.

Describe the solution

  1. Add tying material length in centimeters (or meters) to item description, converted from inches or feet.
  2. Rename small strings to short strings, to be consistent with short/long rope naming.
  3. Allow wearing short ropes, just like long ropes, as they're apparently long enough to wrap around the torso too.
  4. Changed grappling hook to be disassembled into rope and metal, rather than being used as a rope for recipes right away.
  5. Add short and long cordage pieces and modify requirements to use them. Also, overall 2 times less material is now needed to make cordage from plant material; going by weight, material weight was very excessive (and still is, though less so).
  6. Modify most recipes to use cordage/rope requirement, in which previously only a string was specified as valid coponents; some still need high-quality strings or ropes, mostly non-improvised bows and crossbows or if a string is used as a fuse for bomb.
  7. Add "dry plant" material to be used by ropes and strings made out of cordage; later this material would also be used for things like straw baskets. Currently has the same properties as paper.
  8. Add short vine item, the product of cutting a long vine into pieces that can replace a short rope.
  9. Add flags related to their "wearable" function to ropes: WATER_FRIENDLY and OVERSIZE.

Describe alternatives you've considered

None.

Testing

Loaded the game with changes, verified that no errors happened, looked at some affected recipes and made sure that components displayed are correct.

Additional context

I noticed that if one recipe has the same requirement listed twice anywhere in it, then game complains about possible infinite loop during loading (though in fact there's none); this is probably not intended.

@curstwist curstwist added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact labels Nov 25, 2019
@FuelType-Memes
Copy link
Contributor

Possible addition to current cordage:
Plastic strings: https://www.youtube.com/watch?v=-zqp_zA6m-w
Plastic ropes: https://www.youtube.com/watch?v=OINRkRf3aFs

@Rail-Runner
Copy link
Contributor Author

Possible addition to current cordage:
Plastic strings: https://www.youtube.com/watch?v=-zqp_zA6m-w
Plastic ropes: https://www.youtube.com/watch?v=OINRkRf3aFs

Yes, that's part of the reason behind this change, but will be a later addition. Other options for materials are duct tape, willow bark, rawhide, and plastic bags, maybe something else as well.

@ZhilkinSerg ZhilkinSerg merged commit 172f04f into CleverRaven:master Dec 4, 2019
I-am-Erk pushed a commit to I-am-Erk/Cataclysm-DDA that referenced this pull request Dec 6, 2019
* Rope and cordage overhaul

* Add extra comments about weight/length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants