Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update evac shelters and bring them (mostly) up to code #35847

Merged
merged 10 commits into from
Dec 4, 2019

Conversation

I-am-Erk
Copy link
Member

@I-am-Erk I-am-Erk commented Dec 4, 2019

Summary

SUMMARY: Content "Updates evac shelter loot supplies, adds a bunch of new aspects, and adds toilets"

Purpose of change

Although understocked by lore, the evac shelters remain one of the most obvious examples of where our loot tables are woefully underrepresented. They don't even have toilets.

Describe the solution

  • Adds toilets to the basements of evac shelters
  • Changes item spawning to use SUS (specific use storage) itemgroups for the lockers, cabinets, and new sinks in the shelter. These furnitures now contain a much larger selection of items including first aid kits, fire extinguishers, radios, batteries, flashlights, cleaning supplies, and bottled water.
  • Adds two new items: a pamphlet from FEMA briefly and uselessly describing the purpose of the shelter and what to do in it, and a terrible tasting protein bar with a humorous backstory.

Also updates the shelter_2 map very significantly, to make it more feasible to put a faction base in there. That was actually my goal with this PR, but as usual I got sidetracked.

Describe alternatives you've considered

This is going to have a major impact on early game difficulty. I would like to balance it a bit by making a 'vandalized' variant of each shelter, with much less loot and graffiti all over the place. NPC looters should also have a major impact on it since they should all know these are places to go for good early-game loot.

Testing

Not yet.
image
New evac shelter layout

image
New basement

image
Stocked up, mostly with junk

image
Our much more inept version of FEMA loves you and just wants you to be happy.

@I-am-Erk I-am-Erk added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Dec 4, 2019
@I-am-Erk I-am-Erk marked this pull request as ready for review December 4, 2019 01:43
@ZhilkinSerg ZhilkinSerg merged commit 1d0a485 into CleverRaven:master Dec 4, 2019
@Lamandus
Copy link
Contributor

Lamandus commented Dec 4, 2019

is it intended, that flashlights are missing any batteries? Like there is none in the evec-shelters?
Wouldn't it be better for them to be preloaded with these?

@I-am-Erk
Copy link
Member Author

I-am-Erk commented Dec 4, 2019

It wasn't intended, but I don't think it is out of line. On the next pass I'll add a chance for batteries to spawn separately in the lockers, but it won't be high

I-am-Erk added a commit to I-am-Erk/Cataclysm-DDA that referenced this pull request Dec 6, 2019
@I-am-Erk I-am-Erk deleted the evac-update-1 branch December 6, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants