Don't prompt to save the game

[Kodiologist]

Summary

SUMMARY: None

Purpose of change

This prompt seems pointless, because if you hit "S" by accident, you can reload your game immediately with nothing lost. Saving overrwites your old save, of course, but because Cata is a roguelike, the expectation is that you regard every turn as permanent.

[Zireael07]

I don't know any game that allows you to save with a single key press and doesn't prompt.
Either the process to save is more convoluted (several menus/several keys) or there's a prompt. Or both, sometimes.

[Kodiologist]

Hitting "S" should require hitting the "S" key while holding the Shift key, unless you have Caps Lock on, which is asking for trouble.

[Kodiologist]

I suppose there's no reason it couldn't be Control-S like most programs these days. Shift-S is just a roguelike tradition.

[mkikt4743]

Nah, I'd say just leave it in, works fine as is. Plus, some people enjoy save scumming to test new features or fight new enemies. I think everyone is fine with pressing Y, and if not, just bind quick save

[ZhilkinSerg]

That is bad UX.

[kevingranade]

This is such a small function that it seems pretty reasonable to add a default-unbound SAVE_NO_PROMPT action for people that prefer it.

[Kodiologist]

@kevingranade I think ACTION_QUICKSAVE might already be that, but I'm not sure.

[kevingranade]

Yea it's very nearly the same, but a bit more involved

Cataclysm-DDA/src/game.cpp

Lines 11251 to 11267 in c238070

	void game::quicksave()
	{
	//Don't autosave if the player hasn't done anything since the last autosave/quicksave,
	if( !moves_since_last_save ) {
	return;
	}
	add_msg( m_info, _( "Saving game, this may take a while" ) );
	popup_nowait( _( "Saving game, this may take a while" ) );
	time_t now = time( nullptr ); //timestamp for start of saving procedure
	//perform save
	save();
	//Now reset counters for autosaving, so we don't immediately autosave after a quicksave or autosave.
	moves_since_last_save = 0;
	last_save_timestamp = now;
	}