-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding More Furniture #35272
Adding More Furniture #35272
Conversation
Adding 26 different pieces of furniture, and 9 items, with a recipe and snippet type.
You need to spawn your new furniture somewhere, otherwise it's a dead weight. |
I mean, define "Dead Weight." They aren't going to harm anything and are fully available for mappers without making them define new furniture. |
We don't need stuff in the code (be it c++ or json) that isn't used anywhere in the game. In the past we had several cleanings of the code from unused stuff. |
Co-Authored-By: matskuman5 <[email protected]>
Co-Authored-By: matskuman5 <[email protected]>
Co-Authored-By: matskuman5 <[email protected]>
Co-Authored-By: matskuman5 <[email protected]>
Co-Authored-By: matskuman5 <[email protected]>
Co-Authored-By: matskuman5 <[email protected]>
Co-Authored-By: matskuman5 <[email protected]>
Co-Authored-By: matskuman5 <[email protected]>
Co-Authored-By: matskuman5 <[email protected]>
Co-Authored-By: matskuman5 <[email protected]>
Co-Authored-By: DaviBones <[email protected]>
Co-Authored-By: DaviBones <[email protected]>
Co-Authored-By: DaviBones <[email protected]>
Co-Authored-By: DaviBones <[email protected]>
Could you add theater seats to the movie theater in the mall? mall_a_11 and mall_a_20 |
house_patio would be a good place for the charcoal grill. |
Can you resolve conflicts please? |
@WhaleyWhaley boop |
Hoping this gets merged. Charcoal grill and drumset would be great to use! |
I'd be happy to merge this if the conflicts were fixed, I can't do that easily on my phone though. |
@WhaleyWhaley care to resolve conflicts? |
Need conflict resolution. Feel free to rebase and reopen. |
Summary
SUMMARY: Content "Adds new furniture"
Purpose of change
Adding 26 different pieces of Furniture, and 9 items, with a recipe and snippet type.
Furniture Added -
Charcoal Grill, Sandwich Board, Yard Flamingo, Birdfeeder, Traffic Cone, Taxidermy'd Bear, Foodperson Cardboard Cutout, Fishbowl, Dollhouse, Huge Teddy Bear, Drumset, TV Tray, Litterbox, Postal Boxes, Fire Hydrant, Floral Print Armchair, Beanbag Chair, Purple Velvet Chair, Plastic Lawn Chair, Foot Stool, Leather Chair, Gaming Chair, Wine Rack, Baby Gate, Turnstile, Door mats (With Snippets)
The furniture should add some immersion or flavor. A lot of houses/buildings feel "empty" so hopefully this can be used in the future to add some depth to some locations. I also added the furniture to a few locations.
Many of the furniture types are deployable, especially the decorative ones, because ideally more furniture would mean more base decoration and that way you can wield it and carry it away instead of dragging it.
Describe the solution
It just adds furniture.
Describe alternatives you've considered
The alternative is less furniture.
Testing
Spawned each piece. The ones that can be deployed I deployed and undeployed.
Additional context
Some sprites I made to save SDG some time.