Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RuntimeConfiguration.NotRelease #1

Closed
wants to merge 699 commits into from
Closed

Add RuntimeConfiguration.NotRelease #1

wants to merge 699 commits into from

Conversation

danmoseley
Copy link
Owner

To double check:

alexperovich and others added 30 commits October 14, 2021 22:06
…net#8044)

[main] Update dependencies from dotnet/xliff-tasks dotnet/arcade
…net#8049)

[main] Update dependencies from dotnet/xliff-tasks dotnet/arcade
…#8051)

[main] Update dependencies from dotnet/xharness dotnet/arcade
…015.3 (dotnet#8052)

[main] Update dependencies from dotnet/roslyn
Includes last 2MB of system logs when non-successful XHarness run happens.
…0211018.1 (dotnet#8058)

[main] Update dependencies from dotnet/sourcelink
* Update the script to include symbolExclusion file

* Review comments

* Revert some change

* Update eng/common/post-build/symbols-validation.ps1

Co-authored-by: Michelle McDaniel <[email protected]>

* updated

Co-authored-by: Michelle McDaniel <[email protected]>
…et/sourcelink (dotnet#8062)

[main] Update dependencies from dotnet/xliff-tasks dotnet/arcade dotnet/sourcelink
When the new target feed specifications were created, they collapsed down the feed specs for shipping and non-shipping package asset selection in cases where the target would be the same feed. This subtlety was required though, since in case of a stable build, we want just the shipping packages to go to a separate, newly created feed. The current code correct substitutes this if the TargetFeedSpecifications are broken out for ShippingOnly and NonShippingOnly, but there are a number of channels that did not break them out. Instead, it tried to send shipping packages to the isolated feed, and all packages to the non-isolated feed.

To fix this, separate out the TargetFeedSpecifications and put a check into the constructor to ensure that this can't be done accidentally.
Also
- Do a little refactoring for clarity.
- Add a test to ensure that this throws
* Fixup automatically create feed permissions
Tighten up the feed permissions used when creating new feeds on the fly, or when publishing signed assets, and do a bit of refactoring in the process.
- Put internal feeds into the internal project, rather than the organization. This is where they should have been from the beginning. There was mainly confusion about project vs. org scoped feeds when this was created.
- Tweak the default feed permissions so that:
  - Members of dnceng get read perms on the local view (this avoids an issue where we used to have to add people as Contributors). This is done by patching the local feed view after feed creation.
  - Admins get ownership
  - the internal and collection build service accounts get write access
- Added some nice NYI exceptions that should fire if we ever change the organization or project that we are running in.
- Update references to the task, in PublishSignedAssets.proj and SetupTargetFeedConfigV3, to use the new task parameters.

Refactoring:
- Remove SetupTargetFeeds.proj (v2 support), which is unused. I chose to do this because it also contain a reference to CreateAzureDevOpsFeed
- Set the default publishing version to 3
- Remove IsInternal as a feed task creation parameter and replace it with the AzDO project. The AzDO project defines the visibility, and this cleans up a little of the dnceng-isms and enables moving them into some helper methods
- Add helper methods for determining some aspects of the feed names
- Refactor some variable names to make them clearer

* Respond to feedback

* Respond to feedback

* Switch back to setting org feed permissions explicitly instead of through a view

* Fix isolated feed issue
When the new target feed specifications were created, they collapsed down the feed specs for shipping and non-shipping package asset selection in cases where the target would be the same feed. This subtlety was required though, since in case of a stable build, we want just the shipping packages to go to a separate, newly created feed. The current code correct substitutes this if the TargetFeedSpecifications are broken out for ShippingOnly and NonShippingOnly, but there are a number of channels that did not break them out. Instead, it tried to send shipping packages to the isolated feed, and all packages to the non-isolated feed.

To fix this, separate out the TargetFeedSpecifications and put a check into the constructor to ensure that this can't be done accidentally.
Also
- Do a little refactoring for clarity.
- Add a test to ensure that this throws
When the code for running the configure step in sdl validation was moved, the quotes were removed from the tool args. This prevents us from upgrading the version of guardian, because newer versions of guardian get confused by the triangle brackets. This change adds back the quotes around each tool arg.
* uninstall app after timeout

* address feedback

* Update src/Microsoft.DotNet.Helix/Sdk/tools/xharness-runner/xharness-helix-job.android.ps1

Co-authored-by: Přemek Vysoký <[email protected]>

* remove apps in case of installation failure

* add function Remove-Apps

* formatting

* print message before removing apps

Co-authored-by: Přemek Vysoký <[email protected]>
…019.8 (dotnet#8073)

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.21518.6 -> To Version 7.0.0-beta.21519.8

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…exist (dotnet#8079)

If the $InputPath parameter is a directory that doesn't exist, we should exit sourcelink-validation early.
…021.5 (dotnet#8083)

[main] Update dependencies from dotnet/arcade
- Don't call GetFeedVisibilityTag when the feed name is explicitly specified
- Alter GetFeedVisibilityTag to support non-dnceng
- Alter the default permissions setup method to specify null permissions for non-dnceng
…t/xharness (dotnet#8086)

[main] Update dependencies from dotnet/arcade dotnet/sourcelink dotnet/xharness
…021.3 (dotnet#8089)

[main] Update dependencies from dotnet/roslyn
…024.1 (dotnet#8090)

[main] Update dependencies from dotnet/arcade
* Making ConvertPortablePdbsToWindowsPdbs settable

* added comments
Superseded by MicrosoftNetFrameworkReferenceAssembliesVersion which is exposed by the SDK
mmitche and others added 29 commits January 26, 2022 12:30
* .NET 7 preview flow

* Add flow from the razor-compiler

* Update mono/linker
…125.11 (dotnet#8398)

[main] Update dependencies from dotnet/arcade
* Avoid project evaluations for single tfms

To avoid additional project evaluations when a project doesn't multi-target, don't set the SetTargetFramework property and undefine the TargetFramework property. For consistency also undefine the RuntimeIdentifier property when a project is RID agnostic. This mimics the msbuild's Common.targets behavior which is disabled because the SkipGetTargetFrameworkProperties attribute is set to the annotated P2Ps.

This change shows a drastic speed improvement when building the libs.ref projects in dotnet/runtime and changing the projects to use the TargetFramework property instead of TargetFrameworks when the project doesn't multi-target.

* Update BinPlace.targets

* Update BinPlace.targets
Update the credentials for the merge and code mirror jobs to use an explicit variable group
…net#8400)

* Update dependencies from https://github.com/dotnet/xliff-tasks build 20220126.1

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.22075.2 -> To Version 1.0.0-beta.22076.1

* Update dependencies from https://github.com/dotnet/arcade build 20220126.9

Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.SignTool , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22075.11 -> To Version 7.0.0-beta.22076.9

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…127.8 (dotnet#8407)

[main] Update dependencies from dotnet/arcade
…net#8411)

[main] Update dependencies from dotnet/arcade dotnet/xliff-tasks
…0220129.2 (dotnet#8412)

[main] Update dependencies from dotnet/sourcelink
…20124.1 (dotnet#8413)

[main] Update dependencies from dotnet/xharness
…130.1 (dotnet#8414)

[main] Update dependencies from dotnet/arcade
…tnet/winforms) (dotnet#8395)

Moving to latest version of the package in order to consume dotnet/templating#4267. This unblocks adoption of the template localizer in the winforms repo. See dotnet/winforms#6319 (comment) for context on the bug being fixed.
…0220131.2 (dotnet#8419)

[main] Update dependencies from dotnet/sourcelink
We've come across a few cases where CG fails due to environment issues (missing .NET).
Continue on error as this is non-critical functionality.
dotnet/runtime was the only consumer that dependent on runtime specific
.NETStandard tfms. Now that we are removing them with
dotnet/runtime#64610 we can also delete the
hacks to make them work in the TargetFramework package.

Also renaming the project from
Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk to
Microsoft.DotNet.Build.Tasks.TargetFramework as doesn't need to be an
msbuild sdk anymore and consuming it as a package will reduce evaluation
time.
…otnet#8421)

* Fix TargetFramework package via multiTargeting

The package's props and targets files need to be imported in both the outer and the inner build. Hence, adding a buildMultiTargeting folder that redirects to the build folder.

Also fixing the Binplace conditions which are now evaluated too early.
…0220201.3 (dotnet#8422)

[main] Update dependencies from dotnet/sourcelink
This starts sending telemetry to Kusto. Application Insights will be eventually deprecated.

More details about this here: dotnet/core-eng#14495
…g to Important (it's brief) and produce warnings for missing queues. (dotnet#8426)
)

[main] Update dependencies from dotnet/arcade dotnet/linker
* Don't evaluate outer build targets in inner build

This is a nit change but it showed up in an msbuild binlog and hence I felt like cleaning this up, now that we already split between inner and outer build via nuget conventions.

* Update Microsoft.DotNet.Build.Tasks.TargetFramework.targets

* Update Microsoft.DotNet.Build.Tasks.TargetFramework.props
* Dedupe workload packs

* Replace HashSet with List
@danmoseley danmoseley closed this Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.