-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for Helix SDK XHarness tasks #7358
Merged
premun
merged 23 commits into
dotnet:main
from
premun:prvysoky/xharness-helix-sdk-tests
May 11, 2021
Merged
Add unit tests for Helix SDK XHarness tasks #7358
premun
merged 23 commits into
dotnet:main
from
premun:prvysoky/xharness-helix-sdk-tests
May 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b9d15c7
to
ad16487
Compare
MattGal
approved these changes
May 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (it's huge so I skimmed most of it). Lots of missing license headers.
missymessa
reviewed
May 7, 2021
missymessa
approved these changes
May 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
greenEkatherine
approved these changes
May 10, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
XHarness tasks in Helix SDK are getting more and more complex and we don't have them tested. In order to prepare for even more new functionality (dotnet/xharness#590), we need to add unit tests.
Changes
CreateXHarnessAndroidWorkItemsTests
andCreateXHarnessAppleWorkItemsTests
ProvisioningProfileProvider
+ tests