Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for Helix SDK XHarness tasks #7358

Merged
merged 23 commits into from
May 11, 2021

Conversation

premun
Copy link
Member

@premun premun commented May 7, 2021

Motivation
XHarness tasks in Helix SDK are getting more and more complex and we don't have them tested. In order to prepare for even more new functionality (dotnet/xharness#590), we need to add unit tests.

Changes

@premun premun force-pushed the prvysoky/xharness-helix-sdk-tests branch from b9d15c7 to ad16487 Compare May 7, 2021 12:13
Copy link
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (it's huge so I skimmed most of it). Lots of missing license headers.

Copy link
Member

@missymessa missymessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM shipit

@premun premun merged commit de080b2 into dotnet:main May 11, 2021
@premun premun deleted the prvysoky/xharness-helix-sdk-tests branch May 11, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreateXHarnessAndroidWorkItems fails if previous .zip file exists
4 participants