Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FreeBSD packages #8331

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Update FreeBSD packages #8331

merged 1 commit into from
Jan 25, 2022

Conversation

Thefrank
Copy link
Contributor

removes lttng-ust (already merged here dotnet/runtime#63567) by @wfurt
updates base version of pkg to 1.17
adds openssl
updates FreeBSD 12.2 to 12.3
removes FreeBSD 11.x (EOL)

@Thefrank
Copy link
Contributor Author

@wfurt Will this break CI? net6 is not aware of the removal of lttng and I (think?) other repos consume this to make the docker/CI images. If this will break things then either a) it needs to wait until net7 or b) lttng removal needs backporting

wfurt
wfurt previously approved these changes Jan 24, 2022
@wfurt
Copy link
Member

wfurt commented Jan 24, 2022

I think this will be OK. The fact that we build new image does not matter (at the moment) for older versions. This will publish new image and tag and it does not matter until somebody pulls this into particular runtime build.

@Thefrank
Copy link
Contributor Author

not sure why the initial PR had CI failures but I rebased and force-pushed. hopefully this resolves it

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt
Copy link
Member

wfurt commented Jan 25, 2022

anything else you want to see @mthalman? This looks good to go.

@mthalman
Copy link
Member

LGTM

@wfurt wfurt merged commit 86a931a into dotnet:main Jan 25, 2022
@Thefrank Thefrank deleted the Thefrank-fbsd-1 branch January 25, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants