-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ASP.NET Core runtime version test #7227
Add ASP.NET Core runtime version test #7227
Conversation
Forgot to make it only run on Windows lol. One sec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, was going to make the windows comment but you beat me to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I can see one possible way this could fail - if someone went and changed the the type of .NET in the unit tests from SDK to ASP.NET Runtime. Then we would be testing ASPNET vs ASPNET and it would always succeed. But I guess other parts of the unit tests would fail and this won't really happen.
@@ -1,10 +1,11 @@ | |||
<Project> | |||
<PropertyGroup> | |||
<IncludeDotNetCli Condition=" '$(IncludeDotNetCli)' != 'true' ">false</IncludeDotNetCli> | |||
<AspNetCoreRuntimeVersion>6.0.0-preview.2.21154.6</AspNetCoreRuntimeVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also please use this property inside XHarnessRunner.targets
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@premun Check out the latest push and see if you think this will work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonfortescue it didn't work out of the box? without pulling the property in its own file?
I think the whole DotNetCli is included for Helix SDK already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am meaning to say - did you just try using the property without any other changes?
src/Microsoft.DotNet.Helix/Sdk/tools/xharness-runner/XHarnessRunner.targets
Outdated
Show resolved
Hide resolved
@jonfortescue seems like
If you went few commits back and didn't pull the property in its own new file, and just define it in I might be wrong but can you verify that please? |
@premun oooh neat. let's test it. |
src/Microsoft.DotNet.Helix/Sdk/tools/dotnet-cli/DotNetCli.props
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, should work well!
Also we should probably move to .NET 6.0 preview 3 in Arcade
Closes #7022.
Adds a test to verify that the hardcoded version of the ASP.NET Core runtime matches the .NET SDK version.
Example console logs (from UnitTests.proj): Passing
Example console logs (from testing proj): Passing, Failing due to mismatch, Failing due to invalid version number
To double check: