Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for publishing #7346

Merged
13 commits merged into from
Jul 1, 2021
Merged

Tests for publishing #7346

13 commits merged into from
Jul 1, 2021

Conversation

epananth
Copy link
Member

@epananth epananth commented May 5, 2021

To double check:

riarenas
riarenas reviewed May 11, 2021
View reviewed changes
src/Microsoft.DotNet.Build.Tasks.Feed.Tests/PublishToSymbolServerTest.cs Outdated Show resolved Hide resolved
src/Microsoft.DotNet.Build.Tasks.Feed.Tests/PublishToSymbolServerTest.cs Outdated Show resolved Hide resolved
src/Microsoft.DotNet.Build.Tasks.Feed.Tests/PublishToSymbolServerTest.cs Outdated Show resolved Hide resolved
src/Microsoft.DotNet.Build.Tasks.Feed.Tests/PublishToSymbolServerTest.cs Outdated Show resolved Hide resolved
src/Microsoft.DotNet.Build.Tasks.Feed.Tests/PublishToSymbolServerTest.cs Show resolved Hide resolved
src/Microsoft.DotNet.Build.Tasks.Feed.Tests/PublishToSymbolServerTest.cs Outdated Show resolved Hide resolved
src/Microsoft.DotNet.Build.Tasks.Feed.Tests/PublishToSymbolServerTest.cs Outdated Show resolved Hide resolved
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs Show resolved Hide resolved
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestBase.cs Show resolved Hide resolved
@epananth epananth marked this pull request as ready for review June 30, 2021 00:10
@epananth
Copy link
Member Author

I had to change

Private readonly ExponentialRetry handler to public, cos the tests were timing out.

riarenas
riarenas approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@riarenas riarenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're missing a test case for the retries where we fail at least once and then succeed. Otherwise this LGTM

@epananth
Copy link
Member Author

added the missing test case, as discussed. :)

@epananth epananth requested a review from alexperovich June 30, 2021 22:07
@epananth epananth added the auto-merge Automatically merge PR once CI passes. label Jun 30, 2021
@ghost
Copy link

ghost commented Jun 30, 2021

Hello @epananth!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@epananth
Copy link
Member Author

epananth commented Jul 1, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost merged commit c206f6f into dotnet:main Jul 1, 2021
@epananth epananth deleted the tests-for-publishing branch July 6, 2021 17:46
@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riarenas riarenas riarenas approved these changes

@alexperovich alexperovich alexperovich approved these changes

Assignees
No one assigned
Labels
auto-merge Automatically merge PR once CI passes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epananth @alexperovich @riarenas