Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] update the MicrosoftNetSdkWorkloadManifestReaderVersion used #7880

Closed
MichaelSimons opened this issue Sep 10, 2021 · 5 comments
Assignees
Labels
Detected By - Customer Issue was reported by a customer Ops - First Responder

Comments

@MichaelSimons
Copy link
Member

Currently MicrosoftNetSdkWorkloadManifestReaderVersion 6.0.100-preview.5.21254.11 is used - https://github.com/dotnet/arcade/blob/release/6.0/eng/Versions.props#L86. In Preview 7 there were some breaking changes made with - dotnet/sdk@b8ade8e. Please update Arcade to build with a newer version and address the resulting build breaks:

  /repos/tarball1/src/arcade.474307e526160c813c9fd58060eb8356ccca6099/artifacts/source-build/self/src/src/Microsoft.DotNet.Build.Tasks.Workloads/src/GenerateWorkloadMsis.cs(124,33): error CS1061: 'BaseWorkloadDefinition' does not contain a definition for 'Platforms' and no accessible extension method 'Platforms' accepting a first argument of type 'BaseWorkloadDefinition' could be found (are you missing a using directive or an assembly reference?) [/repos/tarball1/src/arcade.474307e526160c813c9fd58060eb8356ccca6099/artifacts/source-build/self/src/src/Microsoft.DotNet.Build.Tasks.Workloads/src/Microsoft.DotNet.Build.Tasks.Workloads.csproj]
  /repos/tarball1/src/arcade.474307e526160c813c9fd58060eb8356ccca6099/artifacts/source-build/self/src/src/Microsoft.DotNet.Build.Tasks.Workloads/src/GenerateWorkloadMsis.cs(124,58): error CS1061: 'BaseWorkloadDefinition' does not contain a definition for 'Platforms' and no accessible extension method 'Platforms' accepting a first argument of type 'BaseWorkloadDefinition' could be found (are you missing a using directive or an assembly reference?) [/repos/tarball1/src/arcade.474307e526160c813c9fd58060eb8356ccca6099/artifacts/source-build/self/src/src/Microsoft.DotNet.Build.Tasks.Workloads/src/Microsoft.DotNet.Build.Tasks.Workloads.csproj]

This is currently impacting source-build as it requires building with the latest bits.

@ghost ghost added the Needs Triage A new issue that needs to be associated with an epic. label Sep 10, 2021
@riarenas
Copy link
Member

This looks like it could be part of the new operational epic, but maybe until that's in place, and since it's impacting source-build, FR?

@ghost ghost removed the Needs Triage A new issue that needs to be associated with an epic. label Oct 8, 2021
@markwilkie
Copy link
Member

@ilyas1974 / @MattGal - thoughts?

@ilyas1974 ilyas1974 added Detected By - Customer Issue was reported by a customer Ops - First Responder labels Oct 15, 2021
@ilyas1974
Copy link
Contributor

As we are still ramping up in the operations space and this is something that is needed in the short term, I am adding it to FR.

@MattGal
Copy link
Member

MattGal commented Oct 18, 2021

Oops also needed a release/6.0 version

MattGal added a commit that referenced this issue Oct 18, 2021
@MattGal
Copy link
Member

MattGal commented Oct 18, 2021

Both PRs are merged now, and will flow with the regular dependency flow. Having moved forward to an RTM version of the package I'm optimistically closing this, @MichaelSimons please reactivate if I've missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Detected By - Customer Issue was reported by a customer Ops - First Responder
Projects
None yet
Development

No branches or pull requests

5 participants