Add support for custom Apple XHarness commands in Helix SDK #7380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Common/Microsoft.Arcade.Common/IZipArchiveManager.cs # src/Common/Microsoft.Arcade.Common/ZipArchiveManager.cs # src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/CreateXHarnessAppleWorkItemsTests.cs # src/Microsoft.DotNet.Helix/Sdk.Tests/Microsoft.DotNet.Helix.Sdk.Tests/ProvisioningProfileProviderTests.cs # src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessAndroidWorkItems.cs # src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessAppleWorkItems.cs # src/Microsoft.DotNet.Helix/Sdk/ProvisioningProfileProvider.cs # src/Microsoft.DotNet.Helix/Sdk/XharnessTaskBase.cs
|
@imhameed this PR will allow you to inject all of the commands you need. You won't even have to do I have 1 question: |
As far as I know, I only need to send the app bundle to the simulator or device. |
premun
changed the title
greenEkatherine
approved these changes
May 12, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables to specify
<CustomCommands>metadata on the<XHarnessAppBundleToTest>which will then inject those commands inside of the wrapper scripts we have that set and clean up the iOS simulator/device safely.Android support will come in a follow-up PR.