Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding symbols in SymbolsPublishingExclusion.txt to publish to symbol server #7733

Merged
merged 45 commits into from
Aug 10, 2021

Conversation

epananth
Copy link
Member

@epananth epananth commented Aug 10, 2021

To double check:

Ran a runtime publishing build -> https://dev.azure.com/dnceng/internal/_build/results?buildId=1284774&view=results

Also this is the runtime build -> https://dev.azure.com/dnceng/internal/_build/results?buildId=1284469&view=results

Here is the place where the symbolsExclusion file is uploaded

image

This was missing the previous build, so publishing failed -> https://dev.azure.com/dnceng/internal/_build/results?buildId=1281458&view=artifacts&pathAsName=false&type=publishedArtifacts

@epananth
Copy link
Member Author

Arcade will need an arcade update immediately after this change is merged to main

@epananth epananth requested review from riarenas and mmitche August 10, 2021 02:48
@epananth
Copy link
Member Author

I ran another test with sdk -> https://dev.azure.com/dnceng/internal/_build/results?buildId=1284280&view=results that worked too

@riarenas
Copy link
Member

I see that runtime's publishing still seems to be failing: https://dev.azure.com/dnceng/internal/_build/results?buildId=1285349&view=results

Does that mean this change wasn't responsible for it? Or that a YAML change needs to propagate to runtime? Should we still be tracking that somewhere else?

Is there a way to split this change so that there aren't any side effects between when this gets merged and when Arcade gets updated? There will always be a gap while the official build succeeds. I would think the task change can go first, and the yaml changes should go with the version bump?

@epananth
Copy link
Member Author

Sure I can split this PR into 2 parts, so that the promotion does not break

@epananth
Copy link
Member Author

I did some digging on runtime publishing, looks like its not that change that broke runtime. Its something else may be related to the symUploader API

@markwilkie
Copy link
Member

What do we need to do to unblock?

@epananth epananth added the auto-merge Automatically merge PR once CI passes. label Aug 10, 2021
@ghost
Copy link

ghost commented Aug 10, 2021

Hello @epananth!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Aug 10, 2021

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. DotNet Maestro - Int
  2. Codecov
  3. DotNet Maestro
  4. Dependabot

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

1 similar comment
@ghost
Copy link

ghost commented Aug 10, 2021

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. DotNet Maestro - Int
  2. Codecov
  3. DotNet Maestro
  4. Dependabot

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@epananth epananth merged commit 6c28cee into main Aug 10, 2021
@epananth epananth deleted the excludeSymbols branch September 3, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge PR once CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants