Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MicrosoftNetFrameworkReferenceAssembliesVersion #8093

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Oct 25, 2021

Superseded by the MicrosoftNETFrameworkReferenceAssembliesLatestPackageVersion property which is exposed by the shipping SDK.
The feature in Arcade to reference the netframework reference assemblies was removed in 0f412eb but the MicrosoftNetFrameworkReferenceAssembliesVersion property was missed.

For more details see discussion in dotnet/runtime#60555 (comment).

To double check:

Superseded by MicrosoftNetFrameworkReferenceAssembliesVersion which is exposed by the SDK
@ViktorHofer ViktorHofer requested a review from eerhardt October 25, 2021 20:40
@ViktorHofer ViktorHofer self-assigned this Oct 25, 2021
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Oct 25, 2021

cc @dotnet/roslyn-infrastructure FYI as you are still using that property in both roslyn and roslyn-tools. You probably want to remove its usage in favor of the SDK one. Note that this change should be non breaking for you, as you define the property yourself in Versions.props.
cc @MichaelSimons @marcpopMSFT as dotnet/installer uses the property here: https://github.com/dotnet/installer/blob/1a39c5ae6e482cf9249b9042d2aafaa58da00bda/src/SourceBuild/tarball/content/repos/aspnetcore.proj#L14.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eerhardt
Copy link
Member

One small request in the above description, just in case someone reads this later:

Superseded by the MicrosoftNetFrameworkReferenceAssembliesVersion property which is exposed by the shipping SDK.

The property name is not correct. It should read:

"Superseded by the MicrosoftNETFrameworkReferenceAssembliesLatestPackageVersion property which is exposed by the shipping SDK."

@ViktorHofer
Copy link
Member Author

Thanks. Copy-paste error. Fixed.

@ViktorHofer ViktorHofer merged commit f08de58 into main Oct 26, 2021
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1-1 branch October 26, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants